Skip to content

Commit 08cf2b5

Browse files
authored
pass reactAppApiEndpoint (#1133)
1 parent e7a95af commit 08cf2b5

File tree

5 files changed

+24
-3
lines changed

5 files changed

+24
-3
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## Unreleased
88

9+
## [0.28.10] - 2024-11-04
10+
11+
### Fixed
12+
13+
- Bug with saving remix caused by not passing prop
14+
15+
16+
## [0.28.9] - 2024-11-04
17+
918
### Fixed
1019

1120
- stopped autoscrolling to top on project content change (#1132)

src/components/Editor/EditorInput/EditorInput.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { createRef, useEffect, useRef, useState, useMemo } from "react";
1+
import React, { createRef, useEffect, useRef, useState } from "react";
22
import { DragDropContext } from "@hello-pangea/dnd";
33
import { useDispatch, useSelector } from "react-redux";
44
import { TabPanel, Tabs } from "react-tabs";

src/containers/WebComponentLoader.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ const WebComponentLoader = (props) => {
131131
});
132132

133133
useProjectPersistence({
134+
reactAppApiEndpoint,
134135
user,
135136
project,
136137
justLoaded,

src/containers/WebComponentLoader.test.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ describe("When no user is in state", () => {
204204
justLoaded: false,
205205
user: null,
206206
saveTriggered: false,
207+
reactAppApiEndpoint: "http://localhost:3009",
207208
});
208209
});
209210

@@ -339,6 +340,7 @@ describe("When no user is in state", () => {
339340
hasShownSavePrompt: true,
340341
justLoaded: false,
341342
saveTriggered: false,
343+
reactAppApiEndpoint: "http://localhost:3009",
342344
});
343345
});
344346

@@ -491,6 +493,7 @@ describe("When user is in state", () => {
491493

492494
test("Calls useProjectPersistence hook with correct attributes", () => {
493495
expect(useProjectPersistence).toHaveBeenCalledWith({
496+
reactAppApiEndpoint: "http://localhost:3009",
494497
user,
495498
project: { components: [] },
496499
hasShownSavePrompt: true,

src/hooks/useProjectPersistence.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export const useProjectPersistence = ({
1414
justLoaded,
1515
hasShownSavePrompt,
1616
saveTriggered,
17+
reactAppApiEndpoint,
1718
}) => {
1819
const dispatch = useDispatch();
1920

@@ -31,18 +32,24 @@ export const useProjectPersistence = ({
3132
if (isOwner(user, project)) {
3233
dispatch(
3334
syncProject("save")({
35+
reactAppApiEndpoint,
3436
project,
3537
accessToken: user.access_token,
3638
autosave: false,
3739
}),
3840
);
3941
} else if (user && project.identifier) {
4042
await dispatch(
41-
syncProject("remix")({ project, accessToken: user.access_token }),
43+
syncProject("remix")({
44+
reactAppApiEndpoint,
45+
project,
46+
accessToken: user.access_token,
47+
}),
4248
);
4349
// Ensure the remixed project is loaded, otherwise we'll get in a mess
4450
dispatch(
4551
syncProject("loadRemix")({
52+
reactAppApiEndpoint,
4653
identifier: project.identifier,
4754
accessToken: user.access_token,
4855
}),
@@ -53,7 +60,7 @@ export const useProjectPersistence = ({
5360
}
5461
};
5562
saveProject();
56-
}, [saveTriggered, project, user, dispatch]);
63+
}, [saveTriggered, project, user, dispatch, reactAppApiEndpoint]);
5764

5865
useEffect(() => {
5966
let debouncer = setTimeout(() => {
@@ -64,6 +71,7 @@ export const useProjectPersistence = ({
6471
}
6572
dispatch(
6673
syncProject("save")({
74+
reactAppApiEndpoint,
6775
project,
6876
accessToken: user.access_token,
6977
autosave: true,

0 commit comments

Comments
 (0)