Skip to content

[CC Projects] Extra line added to the start of some code blocks #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[CC Projects] Extra line added to the start of some code blocks #1268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90f612d
Create draft PR for #1267
create-issue-branch[bot] Oct 24, 2025
7c542b9
add prism hook to remove leading blank lines
rammodhvadia Oct 24, 2025
70ef920
update changelog
rammodhvadia Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Changelog

All notable changes to this project will be documented in this file.
All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

Expand All @@ -14,6 +14,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

- Styling design system components used in the web component (#1263)
- Sidebar panel overflow for plugins (#1266)
- Extra lines added at the start of some code blocks (#1267)

## [0.33.0] - 2025-10-15

Expand Down
11 changes: 10 additions & 1 deletion src/components/Menus/Sidebar/InstructionsPanel/InstructionsPanel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,25 @@ import RemoveInstructionsModal from "../../../Modals/RemoveInstructionsModal";
import Prism from "prismjs";
import populateMarkdownTemplate from "../../../../utils/populateMarkdownTemplate";

let prismConfigured = false;
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a module-level variable to track configuration state may cause issues if the component is unmounted and remounted, or in React strict mode where effects run twice. Consider using useRef instead to track whether Prism has been configured within the component's lifecycle.

Copilot uses AI. Check for mistakes.

const InstructionsPanel = () => {
useEffect(() => {
// prism and prism plugin config
Prism.manual = true;
if (Prism.plugins.NormalizeWhitespace) {
if (Prism.plugins.NormalizeWhitespace && !prismConfigured) {
Prism.plugins.NormalizeWhitespace.setDefaults({
"remove-indent": false,
"remove-initial-line-feed": true,
"left-trim": false,
});
Prism.hooks.add("before-sanity-check", function (env) {
if (!env.code) return;

// Remove multiple leading blank lines (empty or whitespace-only)
env.code = env.code.replace(/^(?:\s*\n)+/, "");
});
Comment on lines +32 to +37
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hook is added every time the effect runs (even though guarded by prismConfigured), but is never removed. This could lead to duplicate hooks being registered if the component remounts. Consider either: (1) using a cleanup function to remove the hook, or (2) moving the hook registration outside the component entirely since it's global Prism configuration.

Copilot uses AI. Check for mistakes.
prismConfigured = true;
}
}, []);
const [showModal, setShowModal] = useState(false);
Expand Down
Loading