Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Capture Device lags because of too often rerenders of text/artwork #4

Open
MarshalX opened this issue Oct 3, 2023 · 2 comments

Comments

@MarshalX
Copy link

MarshalX commented Oct 3, 2023

Hi! The built-in camera of Mac lags with interval 1 (default value). Probably because it tries too often to get new artwork and rerender it. Interval 10 is okay.

Possible fixes:

  1. Add cashing for the tracks. Do not rerender on the same track
  2. Add a note about lags with a small interval

Thank you for the script!

@MarshalX MarshalX changed the title Video Capture Device lags because of too often rerenders of text/art Video Capture Device lags because of too often rerenders of text/artwork Oct 3, 2023
@torytang025
Copy link

I got this problem too. When I use this plugin, I got a severe rendering lag. Here is my log.
Before:
Snapshot 2024-01-14 at 11 20 32
After:(With severe rendering lag)
Snapshot 2024-01-14 at 11 21 12

@RayPS
Copy link
Owner

RayPS commented Jan 16, 2024

Sorry for the delay, I just did some investigation, the lag isn't caused by the re-render, but you are right about the caching.
The lag was caused by the communications between the script and Spotify rather than the re-renders.
The script lookup for the current track info every [interval] seconds, somehow Spotify is slow to return the result.
So far I have no idea how to fix this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants