Skip to content

Commit 89de1b2

Browse files
committed
Generalized a test which had adjusted to a (temporary) R-devel issue
1 parent 0dc6a10 commit 89de1b2

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

ChangeLog

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
2025-10-13 Dirk Eddelbuettel <[email protected]>
2+
3+
* DESCRIPTION (Version, Date): Roll micro version and date
4+
* inst/include/Rcpp/config.h: Idem
5+
6+
* inst/tinytest/test_sugar.R: Simplify and generalize the August fix
7+
as we no longer need to control for R-devel which has been corrected
8+
19
2025-09-04 Dirk Eddelbuettel <[email protected]>
210

311
* DESCRIPTION (Version, Date): Roll micro version and date

DESCRIPTION

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Package: Rcpp
22
Title: Seamless R and C++ Integration
3-
Version: 1.1.0.3
4-
Date: 2025-09-04
3+
Version: 1.1.0.4
4+
Date: 2025-10-13
55
Authors@R: c(person("Dirk", "Eddelbuettel", role = c("aut", "cre"), email = "[email protected]",
66
comment = c(ORCID = "0000-0001-6419-907X")),
77
person("Romain", "Francois", role = "aut",

inst/include/Rcpp/config.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
#define RCPP_VERSION_STRING "1.1.0"
3232

3333
// the current source snapshot (using four components, if a fifth is used in DESCRIPTION we ignore it)
34-
#define RCPP_DEV_VERSION RcppDevVersion(1,1,0,3)
35-
#define RCPP_DEV_VERSION_STRING "1.1.0.3"
34+
#define RCPP_DEV_VERSION RcppDevVersion(1,1,0,4)
35+
#define RCPP_DEV_VERSION_STRING "1.1.0.4"
3636

3737
#endif

inst/tinytest/test_sugar.R

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1269,20 +1269,12 @@ expect_equal(cx_col_sums(x), colSums(x), info = "complex / colSums / keep NA / m
12691269
expect_equal(cx_col_sums(x, TRUE), colSums(x, TRUE), info = "complex / colSums / rm NA / mixed input")
12701270

12711271
expect_equal(cx_row_means(x), rowMeans(x), info = "complex / rowMeans / keep NA / mixed input")
1272-
if (getRversion() < "4.6.0") {
1273-
expect_equal(cx_row_means(x, TRUE), rowMeans(x, TRUE), info = "complex / rowMeans / rm NA / mixed input")
1274-
} else {
1275-
## TODO FIXME R-devel has borked rowMeans / colMeans for complex matrices with NA values
1276-
expect_equal(cx_row_means(x, TRUE), apply(x, 1, mean, na.rm=TRUE), info = "complex / rowMeans / rm NA / mixed input")
1277-
}
1272+
expect_equal(cx_row_means(x, TRUE), rowMeans(x, TRUE), info = "complex / rowMeans / rm NA / mixed input")
1273+
expect_equal(cx_row_means(x, TRUE), apply(x, 1, mean, na.rm=TRUE), info = "complex / rowMeans / rm NA / mixed input")
12781274

12791275
expect_equal(cx_col_means(x), colMeans(x), info = "complex / colMeans / keep NA / mixed input")
1280-
if (getRversion() < "4.6.0") {
1281-
expect_equal(cx_col_means(x, TRUE), colMeans(x, TRUE), info = "complex / colMeans / rm NA / mixed input")
1282-
} else {
1283-
## TODO FIXME R-devel has borked rowMeans / colMeans for complex matrices with NA values
1284-
expect_equal(cx_col_means(x, TRUE), apply(x, 2, mean, na.rm=TRUE), info = "complex / rowMeans / rm NA / mixed input")
1285-
}
1276+
expect_equal(cx_col_means(x, TRUE), colMeans(x, TRUE), info = "complex / colMeans / rm NA / mixed input")
1277+
expect_equal(cx_col_means(x, TRUE), apply(x, 2, mean, na.rm=TRUE), info = "complex / rowMeans / rm NA / mixed input")
12861278

12871279
x[] <- NA_complex_
12881280

0 commit comments

Comments
 (0)