Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show warning dialog if any patch fails #2246

Open
3 tasks done
LisoUseInAIKyrios opened this issue Oct 6, 2024 · 2 comments
Open
3 tasks done

feat: Show warning dialog if any patch fails #2246

LisoUseInAIKyrios opened this issue Oct 6, 2024 · 2 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Oct 6, 2024

Feature description

When users patch the wrong version of an app, or they configure a patch option wrong, or something else goes wrong during patching, then Manager should show a dialog warning that patching failed and the app may not install or work correctly.

I'm not sure how Manager can detect a patching failure, but I would speculate that patcher would need to return a value indicating if all patches completed successfully or if any failed.

Motivation

Users do not always understand what a patch exception stack trace is or why that means a failure, and it leads to troubleshooting hassles for others. Issues such as GmsCore support failing to patch, then installation fails because the package name was not changed and the install is trying to update the stock YouTube app.

Situations like this (GmsCore support failed to patch and the user did not notice):
Image

Acknowledgements

  • I have checked all open and closed feature requests and this is not a duplicate.
  • I have chosen an appropriate title.
  • The feature request is only related to ReVanced Manager.
@LisoUseInAIKyrios LisoUseInAIKyrios added the Feature request Requesting a new feature that's not implemented yet label Oct 6, 2024
@oSumAtrIX
Copy link
Member

There are two types of exceptions. Exceptions raised by patches or exceptions raised from elsewhere, such as installing, OOM, etc. Patcher yields a patch result for every executed patch, so the Manager can check for that and display a warning that mentions if any patch has failed. Pairing it with information such as wether a suggested version was patched and other meta info would be useful

@KobeW50
Copy link
Contributor

KobeW50 commented Oct 7, 2024

the Manager can check for that and display a warning that mentions if any patch has failed. Pairing it with information such as wether a suggested version was patched and other meta info would be useful

Perhaps the 'Copy log' button can be on the warning popup as well.

Also, if possible, the warning popup should specify which patches failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

3 participants