You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When users patch the wrong version of an app, or they configure a patch option wrong, or something else goes wrong during patching, then Manager should show a dialog warning that patching failed and the app may not install or work correctly.
I'm not sure how Manager can detect a patching failure, but I would speculate that patcher would need to return a value indicating if all patches completed successfully or if any failed.
Motivation
Users do not always understand what a patch exception stack trace is or why that means a failure, and it leads to troubleshooting hassles for others. Issues such as GmsCore support failing to patch, then installation fails because the package name was not changed and the install is trying to update the stock YouTube app.
Situations like this (GmsCore support failed to patch and the user did not notice):
Acknowledgements
I have checked all open and closed feature requests and this is not a duplicate.
I have chosen an appropriate title.
The feature request is only related to ReVanced Manager.
The text was updated successfully, but these errors were encountered:
There are two types of exceptions. Exceptions raised by patches or exceptions raised from elsewhere, such as installing, OOM, etc. Patcher yields a patch result for every executed patch, so the Manager can check for that and display a warning that mentions if any patch has failed. Pairing it with information such as wether a suggested version was patched and other meta info would be useful
the Manager can check for that and display a warning that mentions if any patch has failed. Pairing it with information such as wether a suggested version was patched and other meta info would be useful
Perhaps the 'Copy log' button can be on the warning popup as well.
Also, if possible, the warning popup should specify which patches failed.
Feature description
When users patch the wrong version of an app, or they configure a patch option wrong, or something else goes wrong during patching, then Manager should show a dialog warning that patching failed and the app may not install or work correctly.
I'm not sure how Manager can detect a patching failure, but I would speculate that patcher would need to return a value indicating if all patches completed successfully or if any failed.
Motivation
Users do not always understand what a patch exception stack trace is or why that means a failure, and it leads to troubleshooting hassles for others. Issues such as GmsCore support failing to patch, then installation fails because the package name was not changed and the install is trying to update the stock YouTube app.
Situations like this (GmsCore support failed to patch and the user did not notice):
Acknowledgements
The text was updated successfully, but these errors were encountered: