Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube): Combine multiple patches into Hide Layout Components #443

Closed
3 tasks done
KobeW50 opened this issue Aug 17, 2023 · 6 comments · Fixed by #3799, #3798 or #3800
Closed
3 tasks done

bug(YouTube): Combine multiple patches into Hide Layout Components #443

KobeW50 opened this issue Aug 17, 2023 · 6 comments · Fixed by #3799, #3798 or #3800
Labels
Bug report Something isn't working

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Aug 17, 2023

Type

Cosmetic

Bug description

Currently, many YT patches are similar in nature to the Hide Layout Components patch, which is confusing.

Steps to reproduce

Look at the patch list for YT.

Relevant log output

NA

Screenshots or videos

No response

Solution

Combine several of the similar patches into the Hide Layout Components patch.

Patches to consider adding are:

  1. Hide album cards

  2. Hide breaking news shelf

  3. Hide crowdfunding box

  4. Hide filter bar

  5. Hide Load more button

Edit: There are probably others considering that this issue is several months old. Search the patches for "Hide" and pretty much all of the potentially relevant ones will appear.

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@KobeW50 KobeW50 added the Bug report Something isn't working label Aug 17, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
@ILoveOpenSourceApplications
Copy link
Contributor

ILoveOpenSourceApplications commented Apr 17, 2024

@LisoUseInAIKyrios, now that Hide 'Load more' button and Hide horizontal shelves has already been moved into layout components. How about the rest mentioned here? @KobeW50, any more suggestions from your end as well?

@KobeW50
Copy link
Contributor Author

KobeW50 commented Apr 17, 2024

KobeW50, any more suggestions from your end as well?

Here's an updated list of patches that can be considered:

SmartSelect_20240417_154046_ReVanced Manager

These all only hide one or two simple elements and don't need to be a standalone patch. Maybe the Hide cast button, Hide autoplay button and Hide captions button patches should be packaged together with the Hide player buttons patch instead of the Hide layout components patch.

I encourage whoever takes on this task to look through the patches themselves to make sure there aren't other patches that I missed. (I also don't know if there are patches that are applicable in the dev branch).

@UfukUstali
Copy link

While I do agree with the general sentiment here depending on the implementation this may end up taking away some amount of freedom from users.

A specific example I have of this is the current state of the Hide Horizontal Shelves, which doesn't seem to allow enabling Continue Watching without also enabling Breaking News or vice versa.

I am just getting started with this repo and if it seems like I am not aware of a feature which can get me the above explained result please let me know.

@oSumAtrIX
Copy link
Member

The patches come with in-app options.

@UfukUstali
Copy link

The patches come with in-app options.

Screenshot_20240430_004201_YouTube.jpg

I am aware of this but as can be seen in the image I provided Hide Horizontal Shelves doesn't seem to allow such granular control (as I described above) over what is enabled and what is not.

@LisoUseInAIKyrios
Copy link
Contributor

@UfukUstali what you are asking (break apart the horizontal shelves to have more fine grained hiding) is not related to what this issue is proposing. This issue is about merging multiple related patches together so there is less to pick when selecting patches. This will not change what can be enabled/disabled in app.

As for the horizontal shelves, there currently is no way to selectively pick which are shown (the only option is to hide or show all of them).

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title suggestion (youtube): Combine patches into the Hide Layout Components patch bug(YouTube): Combine multiple patches into Hide Layout Components Jun 2, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios moved this from Backlog to In progress in Development of ReVanced Oct 22, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios moved this from In progress to Done in Development of ReVanced Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment