Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Sorting options #159

Open
severtheskyline opened this issue Aug 8, 2023 · 7 comments
Open

feat:Sorting options #159

severtheskyline opened this issue Aug 8, 2023 · 7 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@severtheskyline
Copy link

Nothing too crazy, but it would be nice to have options for sorting patches, my suggestions are:

  • Date added (Newest)
  • Date added (Oldest)
  • A-Z
  • Z-A
  • Recently updated
@Ushie
Copy link
Member

Ushie commented Aug 8, 2023

none of these are possible except a-z and z-a

sorting is only possible if we use information from the patches, we don't have information of addition dates etc

@severtheskyline
Copy link
Author

Those 2 would be fine, but having a way to see new patches will work too, maybe showing the changelog of the latest release? Because going to the github, revanced patches, releases and going through all the experimental releases can get annoying even for someone who knows what they are doing

@oSumAtrIX
Copy link
Member

@Ushie By date is possible in the circumstance that it does it the same way that is proposed for ReVanced Manager:

  1. Save the current list of patches
  2. User visits website another time
  3. Compare the saved list of patches and highlight patches that have been not seen since last time

The option could be called something like "New since the last time you have visited this page" and be active automatically/ by default.

This circumstance is what the user will be in the most cases because users who sort by date mostly care to see newly added patches and since this idea exactly fulfils this purpose, it works as a good solution.

@Ushie Ushie moved this to 📋 Backlog in Development of ReVanced Aug 9, 2023
@oSumAtrIX oSumAtrIX added the Feature request Requesting a new feature that's not implemented yet label Jan 7, 2024
@LisoUseInAIKyrios
Copy link

Is there any reason why the website list patches in random order and not alphabetical?

This issue is for sorting options, but the more immediate fix is to permanently sort the patches a-z so they are more organized and easier to browse.

@oSumAtrIX
Copy link
Member

The patches are currently loaded and parsed by ReVanced API. The order of the set of patches is determined by the Set structure (or how the zip entries are read). There is no functional requirements to sort the list of loaded patches as order is irrelevant in the context of ReVanced API/the patch loader. Iirc the website never employed sorting the list, but that could be added

@LisoUseInAIKyrios
Copy link

If it's simple to change, the api could use a SortedSet (TreeSet) and then the website is also fixed as a result.

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Nov 16, 2024

I think the site can add sorting options like suggested in this issue, including alphabetic sorting. This way the project fulfills its own requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
Status: Backlog
Development

No branches or pull requests

4 participants