Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend functionality of@autoupdates #61

Closed
bartvanerp opened this issue Feb 16, 2023 · 1 comment · Fixed by #306
Closed

Extend functionality of@autoupdates #61

bartvanerp opened this issue Feb 16, 2023 · 1 comment · Fixed by #306
Assignees
Labels
enhancement New feature or request

Comments

@bartvanerp
Copy link
Member

The @autoupdates macro works great for streaming data, as long as it is used in very simple cases. I was trying to do a bit more complicated stuff and think I hit almost all possible cases where it fails:

  • Functions in the macro cannot be nested, e.g. inv(cov(q(a)) does not work. So you will have to define foo(x) = inv(cov(x)), after which foo(q(a)) can be called.
  • Conditional evaluations, including if-else statements are not possible. Again this can be circumvented by creating a separate function that includes this logic.
  • Dealing with vectors of variables is ambiguous. As an example it is not possible to create for-loops over q(a) if a is a vector. Also indexing causes issues. Idem, broadcasting also does not work, e.g. mean.(q(a)) fails, whereas this actually seems necessary. For this last part it seems okay to create separate function again as broadcast_foo(...) = foo.(...). (Keep in mind here that some updates directly assign tuple, such as mean_var() and then this broadcasting needs to be more complicated)
@bvdmitri bvdmitri self-assigned this Feb 16, 2023
@bvdmitri bvdmitri added the enhancement New feature or request label Feb 16, 2023
@bartvanerp bartvanerp changed the title Extend functionality from @autoupdates Extend functionality of@autoupdates Feb 16, 2023
@albertpod albertpod moved this to 🤔 Ideas in RxInfer Feb 21, 2023
@albertpod albertpod moved this from 🤔 Ideas to 👉 Assigned in RxInfer Feb 21, 2023
@wouterwln wouterwln added this to the RxInfer 3.1.0 release milestone Mar 15, 2024
@wouterwln
Copy link
Member

I think this is related to #223 as a revamp of the rxinference functionality, so I'll schedule them for the same milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants