Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to check microphone permissions on page load #149

Open
dhdaines opened this issue Feb 21, 2023 · 4 comments
Open

Need to check microphone permissions on page load #149

dhdaines opened this issue Feb 21, 2023 · 4 comments

Comments

@dhdaines
Copy link
Collaborator

dhdaines commented Feb 21, 2023

If ever you deny microphone permissions to a page, the browser (any sensibly secure one) will never ask you again, which means that recording will always fail with permission denied.

We need to detect this situation and warn the user right away, that they will need to grant permissions and reload the page.

We also need to delay the "recording" indicator until the microphone actually record when the browser asks for permission.

@joanise
Copy link
Member

joanise commented Jun 28, 2023

Delaying the recording indicator is done (#154)

Is detecting the permission issue done yet?

@dhdaines
Copy link
Collaborator Author

It will put up a toast with the error it gets from the browser, e.g.:

image

@dhdaines
Copy link
Collaborator Author

so, we could probably improve that error message :)

@joanise
Copy link
Member

joanise commented Jun 28, 2023

Well, OK, we could polish the message, but this issue is still addressed at least. I guess I'll leave it open in case we want to review the error message before closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants