Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove frankenstein code from useAssetsFolder for 2.0.0 release #255

Open
roedoejet opened this issue Apr 3, 2024 · 2 comments
Open

Remove frankenstein code from useAssetsFolder for 2.0.0 release #255

roedoejet opened this issue Apr 3, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@roedoejet
Copy link
Collaborator

No description provided.

@roedoejet roedoejet added the enhancement New feature or request label Apr 3, 2024
@deltork
Copy link
Collaborator

deltork commented Apr 4, 2024

We will have to update the some of the cypress tests as well

@joanise
Copy link
Member

joanise commented May 6, 2024

The "Frankenstein" code refers to

/**
* DEPRECATED
* Toggle the use of an assets folder. Defaults to undefined.
* Previously (<1.2.0) defaulted to 'true'.
* .readalong files should just contain base filenames
* not the full paths to the images.
*/
@Prop() useAssetsFolder?: boolean;
/**
* Define a path for where the image assets are located
* This should be used instead of use-assets-folder.
* Defaults to 'assets/'. The empty string means that
* image paths will not have a prefix added to them.
* Use of the forward slash is optional.
*/
@Prop() imageAssetsFolder: string = "assets/";
and all uses of useAssetsFolder later in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants