Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the live deployment use the published bundle, in sync with npm. #284

Open
joanise opened this issue May 8, 2024 · 1 comment
Open

Make the live deployment use the published bundle, in sync with npm. #284

joanise opened this issue May 8, 2024 · 1 comment

Comments

@joanise
Copy link
Member

joanise commented May 8, 2024

Now, since #281, the live is meant to be in sync with the published web-component, and the latest dev work on main goes to /dev. But the live still rebuilds the bundle as part of the deploy process. Instead, we would want to make sure it stays in sync with the version of web-component published on npmjs.
@joanise
Copy link
Member Author

joanise commented May 23, 2024 •
edited
Loading

Or maybe we should just remove bundle.js from source control, it's a generated artifact, it doesn't really belong in the Git repo...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joanise