Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When editing, the translation tier is not available for editing #328

Open
roedoejet opened this issue Jul 23, 2024 · 2 comments · Fixed by #330
Open

When editing, the translation tier is not available for editing #328

roedoejet opened this issue Jul 23, 2024 · 2 comments · Fixed by #330
Assignees
@deltork
Labels
bug Something isn't working

Comments

@roedoejet
Copy link
Collaborator

and a newly added translation tier does not get saved.
@roedoejet roedoejet added the bug Something isn't working label Jul 23, 2024
@deltork
Copy link
Collaborator

deltork commented Jul 29, 2024

I moved the storage of translation data to the .readalong DOM. This way, we do not have to recreate the elements during the download process and lose user customizations.

@deltork deltork mentioned this issue Jul 29, 2024
Merged
@joanise joanise linked a pull request Sep 11, 2024 that will close this issue
fix: refactoring translations to rely on readalong DOM instead of state #330
Merged
@joanise
Copy link
Member

joanise commented Oct 17, 2024

Reverting main un-fixed this issue.

@joanise joanise reopened this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deltork deltork

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: refactoring translations to rely on readalong DOM instead of state ReadAlongs/Studio-Web
3 participants
@deltork @roedoejet @joanise