Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put a max text size limit on web-api assemble requests #148

Open
joanise opened this issue Feb 7, 2023 · 1 comment
Open

Put a max text size limit on web-api assemble requests #148

joanise opened this issue Feb 7, 2023 · 1 comment

Comments

@joanise
Copy link
Member

joanise commented Feb 7, 2023

@marctessier was able to DOS the web api by sending large text files, and it would not be that hard to do it by accident, so we want a server side (and maybe client side too, in Studio-Web) limit on the length of the text file being sent to the assemble end point.
@joanise
Copy link
Member Author

joanise commented Feb 24, 2023

Fixed client-side with ReadAlongs/Studio-Web#118

Question: do we still want a server side limit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joanise