Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testable-artifact-builder should provide an option to write packages to devDependencies #2

Open
thompsnm opened this issue Mar 21, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@thompsnm
Copy link
Contributor

thompsnm commented Mar 21, 2018

Background:
When testable-artifact-builder runs installSnapshots it adds the test dependencies to the dependencies object in the package.json so that npm won't throw errors about dependency mismatches. However, some projects don't want any modules in the dependencies object. For instance, if a projects is bundled using webpack instead of npm and then is published as a resulting dist then adding modules to the dependencies object will just cause extra installs to occur downstream for no reason. In that case it would be nice if testable-artifact-builder was parameterized so that the user could tell it to add the dependencies to the devDependencies object instead. That would prevent version mismatch errors, but downstream projects wouldn't have to install extraneous dependencies.

AC:

  • Add a --install-as-dev option to the installSnapshots command in testable-artifact-builder that tells it to install test dependencies to the devDependencies object.
@thompsnm thompsnm added the enhancement New feature or request label Mar 21, 2018
@thompsnm thompsnm added this to the v1.1.0 milestone Mar 21, 2018
@thompsnm thompsnm added the good first issue Good for newcomers label Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant