Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Missing support for percentage widths #135

Open
fadookie opened this issue May 24, 2017 · 1 comment
Open

Missing support for percentage widths #135

fadookie opened this issue May 24, 2017 · 1 comment

Comments

@fadookie
Copy link

fadookie commented May 24, 2017

React Native has recently added support for percentage widths.

Tests now fail props validation if a react-native-mock component is passed a percentage width string instead of a number:

Error: Warning: Failed prop type: Invalid prop `style.width` of type `string` supplied to `View`, expected `number`.
@RealOrangeOne
Copy link
Owner

Ooh, that's a nice improvement. I'm kinda suprised proptype failures cause tests to fail though, but hey it is an actual error i guess.

I plan to spend a large amount of time upgrading the project in the coming weeks, i'll make sure to add this to the list of things to check!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants