You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When prompting a user to agree to render YouTube videos, this is displaying as Youtube instead, due to the logic that just capitalizes the first letter --
and service_nicename is just service with hyphens replaced with spaces, and let service = obj.getAttribute('data-service'); -- which is all lower-case.
So data-service="youtube" gets its first letter capitalized, but the T never gets re-capitalized.
I'm not sure if modifying the data-service parameter could cause other conflicts, so a hardcoded conditional around line 471 in complianz.js (as previously linked) of if ( 'youtube' === service_nicename ) service_nicename = 'YouTube'; would probably be the easiest fix (albeit not exactly ideal for modularity, but then ... neither is YouTube's capitalization!)
The text was updated successfully, but these errors were encountered:
When prompting a user to agree to render YouTube videos, this is displaying as Youtube instead, due to the logic that just capitalizes the first letter --
https://github.com/Really-Simple-Plugins/complianz-gdpr/blob/d0c212e6afd4cab95dfb7a610537de137dd7316f/cookiebanner/js/complianz.js#L471
and
service_nicename
is justservice
with hyphens replaced with spaces, andlet service = obj.getAttribute('data-service');
-- which is all lower-case.So
data-service="youtube"
gets its first letter capitalized, but the T never gets re-capitalized.I'm not sure if modifying the
data-service
parameter could cause other conflicts, so a hardcoded conditional around line 471 in complianz.js (as previously linked) ofif ( 'youtube' === service_nicename ) service_nicename = 'YouTube';
would probably be the easiest fix (albeit not exactly ideal for modularity, but then ... neither is YouTube's capitalization!)The text was updated successfully, but these errors were encountered: