Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proguard rule #36

Open
muhrahmatullah opened this issue Mar 19, 2019 · 2 comments
Open

Proguard rule #36

muhrahmatullah opened this issue Mar 19, 2019 · 2 comments

Comments

@muhrahmatullah
Copy link

We used this library in release configuration which proguard turned on but it gave us error
Warning: io.fotoapparat.facedetector.processor.FaceDetectorProcessor: can't find referenced field 'io.fotoapparat.parameter.Size size' in program class io.fotoapparat.preview.Frame

I think it will be great if you can provide proguard rule. thanks

@Diolor
Copy link
Member

Diolor commented Mar 19, 2019

👋
One-rule-fits-all is a bad idea. And well, looks like you don't use Fotoapparat's size and proguard, correctly, remove it.

If you don't want to see this warning you can use dontwarn by proguard/R8 for the elements you don't need.

@muhrahmatullah
Copy link
Author

Thank you for your reply, our current approach is use keep rule so the file don't get obfuscated, but also will try dontwarn and make sure there are no runtime errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants