-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite doc Promise callbacks to async
/await
#1326
Comments
@karelhala I would love to work on this 👀 |
@adithyaakrishna this might need some additional work. We are now in the middle of TypeScript refactoring which will affect the DOCS generators. If you want to help with that you can check this: https://github.com/RedHatInsights/frontend-components#typescript-refactoring |
Sure @Hyperkid123 |
Yup, I will assign you a few easy ones. Gimme a minute |
@adithyaakrishna I can't assign them to you because you are not part of the or but, you can still work on them. Here is a few easier ones you can tackle: The goal is simple. Convert the files to typescript. More details are in the README or you can ping me in the issues directly and I will help you. |
Awesome! Sounds great :) |
@Hyperkid123 I was thinking how about if we add import sorting rule and patternfly-eslint plugin to the current eslint config? |
Replace Promise callback
Since we are working with new Node we no longer need a Promise callback, but we can utilize
async
/await
in doc generation. There are a few functions in packages/docs/functions-generator.js which are still using the older design.The text was updated successfully, but these errors were encountered: