Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite doc Promise callbacks to async/await #1326

Open
karelhala opened this issue Jan 10, 2022 · 7 comments
Open

Rewrite doc Promise callbacks to async/await #1326

karelhala opened this issue Jan 10, 2022 · 7 comments

Comments

@karelhala
Copy link
Collaborator

Replace Promise callback

Since we are working with new Node we no longer need a Promise callback, but we can utilize async/await in doc generation. There are a few functions in packages/docs/functions-generator.js which are still using the older design.

@adithyaakrishna
Copy link
Contributor

@karelhala I would love to work on this 👀

@Hyperkid123
Copy link
Contributor

@adithyaakrishna this might need some additional work. We are now in the middle of TypeScript refactoring which will affect the DOCS generators.

If you want to help with that you can check this: https://github.com/RedHatInsights/frontend-components#typescript-refactoring

@adithyaakrishna
Copy link
Contributor

Sure @Hyperkid123
Could you please assign me or suggest some starter ones? as this would be the first time I am working on refactoring 😶

@Hyperkid123
Copy link
Contributor

Yup, I will assign you a few easy ones. Gimme a minute

@Hyperkid123
Copy link
Contributor

Hyperkid123 commented Jan 18, 2022

@adithyaakrishna I can't assign them to you because you are not part of the or but, you can still work on them.

Here is a few easier ones you can tackle:

#1352
#1353
#1354
#1355

The goal is simple. Convert the files to typescript. More details are in the README or you can ping me in the issues directly and I will help you.

@adithyaakrishna
Copy link
Contributor

Awesome! Sounds great :)
Thanks a lot, @Hyperkid123 🎉

@adithyaakrishna
Copy link
Contributor

@Hyperkid123 I was thinking how about if we add import sorting rule and patternfly-eslint plugin to the current eslint config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants