Add ip address whitelist UI to manage satellites page for itless #2836

florkbr · 2024-05-15T00:22:24Z

Depends on: RedHatInsights/chrome-service-backend#668

Utilizes mbop changes here: RedHatInsights/mbop#105

Adds a simple UI to the manage satellites page to add/remove IP address(es) WRT to our itless environments.

~~Marking as draft until I manually try the API requests in this PR via postman on pre-prod env.~~
EDIT: verified API requests after deploying

codecov-commenter · 2024-05-15T00:31:42Z

Codecov Report

Attention: Patch coverage is 14.58333% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 62.47%. Comparing base (3194dee) to head (c040274).
Report is 13 commits behind head on master.

❗ Current head c040274 differs from pull request most recent head ca648e6. Consider uploading reports for the commit ca648e6 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2836      +/-   ##
==========================================
- Coverage   63.54%   62.47%   -1.07%     
==========================================
  Files         199      202       +3     
  Lines        4301     4397      +96     
  Branches      777      783       +6     
==========================================
+ Hits         2733     2747      +14     
- Misses       1559     1641      +82     
  Partials        9        9

Files	Coverage Δ
src/auth/setCookie.ts	`100.00% <100.00%> (ø)`
src/components/Header/UserToggle.tsx	`93.93% <ø> (ø)`
src/state/atoms/releaseAtom.ts	`100.00% <100.00%> (ø)`
src/state/atoms/utils.ts	`100.00% <100.00%> (ø)`
src/state/chromeStore.ts	`100.00% <100.00%> (ø)`
src/components/Header/Tools.tsx	`63.76% <0.00%> (-0.94%)`	⬇️
src/layouts/SatelliteToken.tsx	`5.88% <0.00%> (-0.37%)`	⬇️
src/utils/debugFunctions.ts	`12.00% <0.00%> (-0.50%)`	⬇️
src/components/Satellite/IPWhitelistTable.tsx	`1.25% <1.25%> (ø)`

Hyperkid123 · 2024-05-15T07:48:11Z

@florkbr do we want this to be baked into chrome? Can this be its own module?

florkbr · 2024-05-15T14:41:13Z

@Hyperkid123 I don't think it necessarily needs to be baked into chrome - I just started from where the UI lived today.

Do you have any suggestions or thoughts on where the new module could/should be placed?

Hyperkid123 · 2024-05-16T07:23:03Z

@florkbr a new module :) Like the widget UI.

…t-to-manage-sat

florkbr · 2024-09-09T20:02:52Z

When deploying this in our itless env I'm seeing the same pod crash loop as noted in: #2922

florkbr · 2024-09-09T22:06:11Z

src/layouts/SatelliteToken.tsx

@@ -38,11 +47,6 @@ const SatelliteToken: React.FC = () => {
      <Page
        className="chr-c-all-services"
        onPageResize={null} // required to disable PF resize observer that causes re-rendring issue
-        header={
-          <Masthead className="chr-c-masthead">


@Hyperkid123 since we are now exposing this as a module from chrome at /insights/satellite - this is causing the insights masthead and nav to render around the module (hence removing the masthead here otherwise we see duplicates).

Does this page require some unique layout?

No - the content is just a bit odd/out of the ordinary as it is 3 utilities.

florkbr · 2024-09-09T22:22:57Z

frontend.yml

@@ -19,6 +19,11 @@ objects:
        manifestLocation: "/apps/chrome/js/fed-mods.json"
        config:
          ssoUrl: ${SSO_URL}
+        modules:
+          - id: 'satellite-token'


@Hyperkid123 I noticed this is duplicated with my changes in chrome-service-backend: RedHatInsights/chrome-service-backend#668. I know this is used for the frontend-operator - but can you explain why we need both? Thanks.

We don't need both. Only the chrome service. This will become relevant and the source of truth once we have the new FEO features.

florkbr · 2024-09-09T22:23:54Z

src/components/RootApp/ScalprumRoot.tsx

@@ -259,7 +258,6 @@ const ScalprumRoot = memo(
                  }
                />
              )}
-              {ITLess() && <Route path="/insights/satellite" element={<SatelliteToken />} />}


Removed the react router route in ScalprumRoot in favor of the exposed module approach.

Hyperkid123 · 2024-09-10T06:49:53Z

frontend.yml

@@ -19,6 +19,11 @@ objects:
        manifestLocation: "/apps/chrome/js/fed-mods.json"
        config:
          ssoUrl: ${SSO_URL}
+        modules:
+          - id: 'satellite-token'


We don't need both. Only the chrome service. This will become relevant and the source of truth once we have the new FEO features.

Hyperkid123 · 2024-09-10T06:50:56Z

src/layouts/SatelliteToken.tsx

@@ -38,11 +47,6 @@ const SatelliteToken: React.FC = () => {
      <Page
        className="chr-c-all-services"
        onPageResize={null} // required to disable PF resize observer that causes re-rendring issue
-        header={
-          <Masthead className="chr-c-masthead">


Does this page require some unique layout?

Hyperkid123 · 2024-09-10T06:52:00Z

/retest

florkbr · 2024-09-10T21:18:18Z

@Hyperkid123 I removed the changes to frontend.yml for now. Let me know if you think this needs anything else! I'll likely still need to follow up with some styling tweaks on the IP whitelist UI itself - but the major flows seems to be working for me.

Hyperkid123

LGTM

florkbr · 2024-09-12T13:39:55Z

The PR build pipeline is still failing due to the CrashLoopBackOff issue mentioned earlier. I've started a thread in our dev-prod channel and will continue investigating on #2922

Add ip address whitelist UI to manage satellites page for itless

ca648e6

florkbr added 2 commits August 13, 2024 23:06

Merge branch 'master' into add-ip-range-input-to-manage-sat

5434805

Merge remote-tracking branch 'upstream/master' into add-ip-range-inpu…

80a7b5c

…t-to-manage-sat

florkbr force-pushed the add-ip-range-input-to-manage-sat branch from 174a06c to 8f7bab3 Compare September 9, 2024 18:19

florkbr marked this pull request as ready for review September 9, 2024 18:20

florkbr requested review from Hyperkid123, ryelo and karelhala as code owners September 9, 2024 18:21

florkbr force-pushed the add-ip-range-input-to-manage-sat branch from ccdf9ca to 5c92b08 Compare September 9, 2024 22:03

florkbr commented Sep 9, 2024

View reviewed changes

florkbr mentioned this pull request Sep 9, 2024

Expose satellite token fed-mod from chrome RedHatInsights/chrome-service-backend#668

Merged

florkbr force-pushed the add-ip-range-input-to-manage-sat branch from 5c92b08 to 767fb92 Compare September 9, 2024 22:20

florkbr commented Sep 9, 2024

View reviewed changes

Hyperkid123 approved these changes Sep 10, 2024

View reviewed changes

Code review comments - convert satellite token to module

a69b2d8

florkbr force-pushed the add-ip-range-input-to-manage-sat branch from 767fb92 to a69b2d8 Compare September 10, 2024 21:15

Hyperkid123 approved these changes Sep 11, 2024

View reviewed changes

Merge branch 'master' into add-ip-range-input-to-manage-sat

42be2f7

florkbr merged commit 20d6a98 into RedHatInsights:master Sep 12, 2024
7 of 9 checks passed

This was referenced Sep 12, 2024

Add back ip whitelist module to frontend.yml operator definition #2930

Merged

Fix SatelliteToken org admin check to handle if user info not loaded #2931

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ip address whitelist UI to manage satellites page for itless #2836

Add ip address whitelist UI to manage satellites page for itless #2836

florkbr commented May 15, 2024 •

edited

Loading

codecov-commenter commented May 15, 2024

Hyperkid123 commented May 15, 2024

florkbr commented May 15, 2024

Hyperkid123 commented May 16, 2024

florkbr commented Sep 9, 2024

florkbr Sep 9, 2024 •

edited

Loading

Hyperkid123 Sep 10, 2024

florkbr Sep 10, 2024

florkbr Sep 9, 2024

Hyperkid123 Sep 10, 2024

florkbr Sep 9, 2024

Hyperkid123 Sep 10, 2024

Hyperkid123 Sep 10, 2024

Hyperkid123 commented Sep 10, 2024

florkbr commented Sep 10, 2024

Hyperkid123 left a comment

florkbr commented Sep 12, 2024

Add ip address whitelist UI to manage satellites page for itless #2836

Add ip address whitelist UI to manage satellites page for itless #2836

Conversation

florkbr commented May 15, 2024 • edited Loading

codecov-commenter commented May 15, 2024

Codecov Report

Hyperkid123 commented May 15, 2024

florkbr commented May 15, 2024

Hyperkid123 commented May 16, 2024

florkbr commented Sep 9, 2024

florkbr Sep 9, 2024 • edited Loading

Choose a reason for hiding this comment

Hyperkid123 Sep 10, 2024

Choose a reason for hiding this comment

florkbr Sep 10, 2024

Choose a reason for hiding this comment

florkbr Sep 9, 2024

Choose a reason for hiding this comment

Hyperkid123 Sep 10, 2024

Choose a reason for hiding this comment

florkbr Sep 9, 2024

Choose a reason for hiding this comment

Hyperkid123 Sep 10, 2024

Choose a reason for hiding this comment

Hyperkid123 Sep 10, 2024

Choose a reason for hiding this comment

Hyperkid123 commented Sep 10, 2024

florkbr commented Sep 10, 2024

Hyperkid123 left a comment

Choose a reason for hiding this comment

florkbr commented Sep 12, 2024

florkbr commented May 15, 2024 •

edited

Loading

florkbr Sep 9, 2024 •

edited

Loading