Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pythonize #6

Open
peteruhrig opened this issue Jan 20, 2022 · 0 comments
Open

Pythonize #6

peteruhrig opened this issue Jan 20, 2022 · 0 comments

Comments

@peteruhrig
Copy link

The current version looks more like a shell script than a Python script:

  • importing ffmpeg but then it is actually using subprocess calls to the command line ffmpeg
  • for the fsgan_cmd, an external script is called with "python3 ..." via a subprocess call
  • same is true of the audio_cmd

I'm not sure all of this is problematic, and the command line interfaces of some of the dependencies used may be more stable than calling functions directly, but it sure looks very odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant