Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On booking move validation #82

Merged
merged 8 commits into from
Aug 29, 2023
Merged

On booking move validation #82

merged 8 commits into from
Aug 29, 2023

Conversation

folix-01
Copy link
Member

No description provided.

@folix-01
Validate slots according to the target gate
add6a54
@folix-01
Black
04972c8
@folix-01
Additional control if property 'gate' exists
28b0784
@folix-01
Add tests
fa780d9
@folix-01
Remove not needed gates
4f52fed
@folix-01
Squashed commit of the following:
c57cc38 
commit d05a432
Author: Andrea Cecchi <[email protected]>
Date:   Mon Aug 28 09:08:39 2023 +0200

    fix code

commit 353db96
Merge: 6ad1c34 fbd846e
Author: Andrea Cecchi <[email protected]>
Date:   Fri Aug 25 17:47:48 2023 +0200

    Merge branch 'master' into unavailable_gates

commit 6ad1c34
Author: Andrea Cecchi <[email protected]>
Date:   Fri Aug 25 17:47:08 2023 +0200

    Show default gates as unavailable in get_gates method, if they are overrided
@folix-01
Extend test + additional control
e8dec63
@folix-01 folix-01 requested review from mamico and cekk August 28, 2023 08:25
@folix-01
Copy link
Member Author

folix-01 commented Aug 28, 2023 •
edited
Loading

Note: we have also the branch uavailable_gates merged here to fix the tests

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5997469998

  • 19 of 20 (95.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 70.225%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/redturtle/prenotazioni/adapters/conflict.py 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
src/redturtle/prenotazioni/restapi/services/available_slots/get.py 1 89.74%
Totals Coverage Status
Change from base Build 5977594354: 0.1%
Covered Lines: 2776
Relevant Lines: 3953
💛 - Coveralls

@folix-01 folix-01 merged commit fe8a51e into master Aug 29, 2023
5 of 10 checks passed
@folix-01 folix-01 deleted the move_validation_45598 branch September 26, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cekk cekk cekk approved these changes

@mamico mamico Awaiting requested review from mamico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@folix-01 @coveralls @cekk