Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

How should the fix for the dependencies be handled? #80

Open
Avey777 opened this issue Jun 23, 2023 · 4 comments
Open

How should the fix for the dependencies be handled? #80

Avey777 opened this issue Jun 23, 2023 · 4 comments

Comments

@Avey777
Copy link

Avey777 commented Jun 23, 2023

I am installing the packages one by one in al_ds and found that the following packages will throw errors when run after installation.

# oauth2client==4.1.3 #bug
# dql==0.5.26 #bug
# snowflake-connector-python==3.0.2 #bug
# firebolt-sdk  #bug

I have not tested the following disabled dependency packages.

# pymapd==0.19.0
# ibm-db>=2.0.9
@Avey777
Copy link
Author

Avey777 commented Jun 23, 2023

@justinclift
For these dependency packages, they should be tested one by one. If there are issues, they can either be fixed or disabled, but there needs to be progress in resolving them. I suggest that for those data sources that are no longer actively updated, if problems occur, they can be directly removed from support.

@justinclift
Copy link
Member

justinclift commented Jun 23, 2023

Yeah, with the exception of the oauth2client package, I reckon disabling those other ones for now is probably the right move.

The oauth2client one makes me nervous though. It will probably turn out to be important, as OAuth is commonly used in web based authentication. So there could be a bunch of people that need it.


That being said, I agree with you. Lets just remove all of these for now (including the oauth2client one) and see how the resulting preview image goes.

It seems like it should go ok, and that will give us a working preview image that people can use. In theory (!). 😄

@Avey777
Copy link
Author

Avey777 commented Jun 23, 2023

I just found that the Python backend cannot run properly after installing these packages locally. Since I am not very familiar with these dependencies, this is only provided as a reference for everyone.

@justinclift
Copy link
Member

No worries. Letting people know is a good idea. 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants