From 7b87d5f83d94a9a1617b9a4d64cf7480e2c85002 Mon Sep 17 00:00:00 2001 From: filipecosta90 Date: Sun, 24 Nov 2024 20:57:43 +0000 Subject: [PATCH 01/11] Smoke test distro build on ubuntu and debian builds --- .github/workflows/ci.yml | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9cb2b2e..e5e5d5b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,6 +3,25 @@ name: CI on: [push, pull_request] jobs: + smoketest-build-distros: + runs-on: ubuntu-latest + env: + ARCH: amd64 + strategy: + matrix: + image: ${{ fromJSON(vars.SMOKE_TEST_IMAGES) }} + container: ${{ matrix.image }} + name: Build ${{ matrix.image }} + steps: + - uses: actions/checkout@v4 + - name: Install dependencies + run: | + sudo apt-get -qq update + sudo apt-get install lcov autoconf automake pkg-config libevent-dev libpcre3-dev libssl-dev + + - name: Build + run: autoreconf -ivf && ./configure && make -j + build-notls: runs-on: ubuntu-latest steps: @@ -107,7 +126,7 @@ jobs: runs-on: macos-latest continue-on-error: true steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v4 - name: Install dependencies run: brew install autoconf automake libtool libevent openssl@${{ matrix.openssl }} - name: Build @@ -122,7 +141,7 @@ jobs: platform: [macos-12] runs-on: ${{ matrix.platform }} steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v4 - name: Install dependencies run: brew install autoconf automake libtool libevent openssl@1.1 - name: Build @@ -135,7 +154,7 @@ jobs: platform: [macos-12] runs-on: ${{ matrix.platform }} steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v4 - name: Install dependencies run: brew install autoconf automake libtool libevent pkg-config - name: Install openssl v1.0.2 From 9df19ab307955c7c8ca6276fe92447ed58d389de Mon Sep 17 00:00:00 2001 From: filipecosta90 Date: Sun, 24 Nov 2024 20:58:42 +0000 Subject: [PATCH 02/11] Smoke test distro build on ubuntu and debian builds --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e5e5d5b..3a5d0f7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,8 +16,8 @@ jobs: - uses: actions/checkout@v4 - name: Install dependencies run: | - sudo apt-get -qq update - sudo apt-get install lcov autoconf automake pkg-config libevent-dev libpcre3-dev libssl-dev + apt-get -qq update + apt-get install lcov autoconf automake pkg-config libevent-dev libpcre3-dev libssl-dev - name: Build run: autoreconf -ivf && ./configure && make -j From cab7b110c1a326e76134fcade8b4d333eae431c6 Mon Sep 17 00:00:00 2001 From: filipecosta90 Date: Sun, 24 Nov 2024 21:01:41 +0000 Subject: [PATCH 03/11] Using ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION in CI smoke build checks and in release due to ubuntu:bionic --- .github/workflows/ci.yml | 3 +++ .github/workflows/release.yml | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3a5d0f7..7d0d09b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,6 +7,9 @@ jobs: runs-on: ubuntu-latest env: ARCH: amd64 + # required by ubuntu:bionic + # https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ + ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true strategy: matrix: image: ${{ fromJSON(vars.SMOKE_TEST_IMAGES) }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d61d922..b585484 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -123,6 +123,9 @@ jobs: needs: build-binary-package env: ARCH: amd64 + # required by ubuntu:bionic + # https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ + ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true strategy: matrix: image: ${{ fromJSON(vars.SMOKE_TEST_IMAGES) }} @@ -149,6 +152,9 @@ jobs: publish-to-apt: env: DEB_S3_VERSION: "0.11.3" + # required by ubuntu:bionic + # https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ + ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true runs-on: ubuntu-latest environment: build needs: smoke-test-packages From 6972f0023d91f18dbca7a8a2d956e15e947a4f3d Mon Sep 17 00:00:00 2001 From: filipecosta90 Date: Sun, 24 Nov 2024 21:04:51 +0000 Subject: [PATCH 04/11] Using ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION in CI smoke build checks and in release due to ubuntu:bionic --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7d0d09b..7a1be1b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,8 +19,8 @@ jobs: - uses: actions/checkout@v4 - name: Install dependencies run: | - apt-get -qq update - apt-get install lcov autoconf automake pkg-config libevent-dev libpcre3-dev libssl-dev + apt-get -qq update -y + apt-get install lcov autoconf automake pkg-config libevent-dev libpcre3-dev libssl-dev -y - name: Build run: autoreconf -ivf && ./configure && make -j From bce9165dd11e4adaf83b8775e09656ebfb4e6d74 Mon Sep 17 00:00:00 2001 From: filipecosta90 Date: Sun, 24 Nov 2024 21:13:22 +0000 Subject: [PATCH 05/11] use checkout@v3 in case of ubuntu 18.04 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7a1be1b..91f3fdf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,7 @@ jobs: container: ${{ matrix.image }} name: Build ${{ matrix.image }} steps: - - uses: actions/checkout@v4 + - uses: ${{ matrix.image == 'ubuntu:18.04' && 'actions/checkout@v3' || 'actions/checkout@v4' }} - name: Install dependencies run: | apt-get -qq update -y From 9b66155d078613883173d389b66a51e36190f706 Mon Sep 17 00:00:00 2001 From: filipecosta90 Date: Sun, 24 Nov 2024 21:16:15 +0000 Subject: [PATCH 06/11] use checkout@v3 in case of ubuntu 18.04 --- .github/workflows/ci.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 91f3fdf..48da3e0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,13 @@ jobs: container: ${{ matrix.image }} name: Build ${{ matrix.image }} steps: - - uses: ${{ matrix.image == 'ubuntu:18.04' && 'actions/checkout@v3' || 'actions/checkout@v4' }} + - name: Checkout Code for ubuntu:bionic + if: matrix.image == 'ubuntu:bionic' + uses: actions/checkout@v3 + + - name: Checkout Code for other versions + if: matrix.image != 'ubuntu:bionic' + uses: actions/checkout@v4 - name: Install dependencies run: | apt-get -qq update -y From b3e62636d0ba6425f7fdeee2c385e1c47c59ed31 Mon Sep 17 00:00:00 2001 From: filipecosta90 Date: Sun, 24 Nov 2024 21:20:06 +0000 Subject: [PATCH 07/11] Continue on error on smoke test --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 48da3e0..b673b2a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -5,6 +5,7 @@ on: [push, pull_request] jobs: smoketest-build-distros: runs-on: ubuntu-latest + continue-on-error: true env: ARCH: amd64 # required by ubuntu:bionic @@ -23,6 +24,7 @@ jobs: - name: Checkout Code for other versions if: matrix.image != 'ubuntu:bionic' uses: actions/checkout@v4 + - name: Install dependencies run: | apt-get -qq update -y From 3b2f6ba31dcc473f79b0d1a8579481ccee12302d Mon Sep 17 00:00:00 2001 From: filipecosta90 Date: Sun, 24 Nov 2024 21:28:09 +0000 Subject: [PATCH 08/11] using same deps on docker build and build steps of ci smoke test --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b673b2a..2b72ae2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,7 +28,9 @@ jobs: - name: Install dependencies run: | apt-get -qq update -y - apt-get install lcov autoconf automake pkg-config libevent-dev libpcre3-dev libssl-dev -y + apt-get install -y \ + build-essential autoconf automake libpcre3-dev libevent-dev \ + pkg-config zlib1g-dev libssl-dev libboost-all-dev cmake flex - name: Build run: autoreconf -ivf && ./configure && make -j From b4562a54045e9a8b36f45895aaca8d4a496550c9 Mon Sep 17 00:00:00 2001 From: filipecosta90 Date: Sun, 24 Nov 2024 21:34:51 +0000 Subject: [PATCH 09/11] noninteractive on smoke test build --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2b72ae2..0c0fa57 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,6 +11,7 @@ jobs: # required by ubuntu:bionic # https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true + DEBIAN_FRONTEND: noninteractive strategy: matrix: image: ${{ fromJSON(vars.SMOKE_TEST_IMAGES) }} From 7cc36c04b9267c7ad8e37d04f97ff716cd3a097b Mon Sep 17 00:00:00 2001 From: filipecosta90 Date: Sun, 24 Nov 2024 21:45:31 +0000 Subject: [PATCH 10/11] Using actions/download-artifact@v3 for release smoke test --- .github/workflows/release.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index b585484..414dc00 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -139,7 +139,15 @@ jobs: exit 1 fi echo "BUILD_ARCH=$BUILD_ARCH" >> $GITHUB_ENV - - name: Get binary packages + - name: Get binary packages for ubuntu:bionic + if: matrix.image == 'ubuntu:bionic' + uses: actions/download-artifact@v3 + with: + name: binary-${{ env.BUILD_ARCH }}-${{ env.ARCH }} + path: binary-${{ env.BUILD_ARCH }}-${{ env.ARCH }} + + - name: Get binary packages for other versions + if: matrix.image != 'ubuntu:bionic' uses: actions/download-artifact@v4 with: name: binary-${{ env.BUILD_ARCH }}-${{ env.ARCH }} From aef4a74e7a87fb68df56f8d6a359b1311f94d8c3 Mon Sep 17 00:00:00 2001 From: filipecosta90 Date: Sun, 24 Nov 2024 21:48:57 +0000 Subject: [PATCH 11/11] Avoid usage of ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION on publish-to-apt --- .github/workflows/release.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 414dc00..b30dc80 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -160,9 +160,6 @@ jobs: publish-to-apt: env: DEB_S3_VERSION: "0.11.3" - # required by ubuntu:bionic - # https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ - ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true runs-on: ubuntu-latest environment: build needs: smoke-test-packages