Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sum in DuplicatePolicyType #111

Open
Shriram-RP opened this issue Nov 10, 2021 · 3 comments
Open

Sum in DuplicatePolicyType #111

Shriram-RP opened this issue Nov 10, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@Shriram-RP
Copy link

I notice that Sum is present as a DuplicatePolicy type in both official documentation and also in some other clients but why is it missing from redistimeseries-go. Is there a way in which we could do this? Or can we add it here?
@filipecosta90 filipecosta90 added the enhancement New feature or request label Nov 10, 2021
@filipecosta90
Copy link
Collaborator

Hi there @Shriram-RP , you're absolutely right, for some reason we've missed it.
Do you want to open a PR addressing it? Or should we fix it? The const's are placed in https://github.com/RedisTimeSeries/redistimeseries-go/blob/master/common.go#L61

@Shriram-RP
Copy link
Author

For some reason I am receiving 403 errir when I am trying to push my code changes.

fatal: unable to access 'https://github.com/RedisTimeSeries/redistimeseries-go.git/': The requested URL returned error: 403

Can you fix it?

@chayim
Copy link
Contributor

chayim commented Nov 14, 2021 •
edited
Loading

Hi @Shriram-RP Can you commit to a fork, and make a Pull request? Then we can review! This might help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chayim @filipecosta90 @Shriram-RP