Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Code : Signals Manager #43

Open
yoyonel opened this issue Apr 2, 2015 · 0 comments
Open

Refactoring Code : Signals Manager #43

yoyonel opened this issue Apr 2, 2015 · 0 comments
Assignees
@yoyonel
Labels
Develop enhancement
Milestone
Future

Comments

@yoyonel
Copy link
Collaborator

yoyonel commented Apr 2, 2015

Refactor code
Section : Signals Manager

Help to :

  • clean code
  • increase robustness
  • increase readability (for comprehension, help debug, ...)
@yoyonel yoyonel self-assigned this Apr 2, 2015
@yoyonel yoyonel added this to the Future milestone Apr 2, 2015
yoyonel pushed a commit that referenced this issue Apr 2, 2015
@ATTYLionelIGN
issue #34 #43
bfc75da 
Refactor the code -> Add Signals Manager.

(Python) Experimentations:
- Singleton pattern
- Abstract/Implementation on classes

Try to solve the issue about the crash of QGIS when we delete the tracking position layer.

Need @remi tests ;)
yoyonel pushed a commit that referenced this issue Apr 2, 2015
@ATTYLionelIGN
issue #43
0654158 
Refactor the code

- Use Signals Manager for manage QTimer (Tracking Position with asynch strategy).
Clean code and typo.
- Use a polymorphic python strategy (use dict for parameters) and 'simulate' multiple behaviours for the same methods/functions.
yoyonel pushed a commit that referenced this issue Apr 3, 2015
@ATTYLionelIGN
issue #43
2255a7c 
Clean the code

Refactor the code
Change typo for name functions/methods
_<name>_ for 'protected' methods
yoyonel pushed a commit that referenced this issue Apr 7, 2015
@ATTYLionelIGN
Issues #43 #44
5471ede 
Update Makefile (for working on Linux, with build/install plug  step)
yoyonel pushed a commit that referenced this issue Apr 8, 2015
@ATTYLionelIGN
Issues #43 #44
feead94 
Clean code,
separate Actions Implementation from signalsmanagers.py (increase encapsulation).
Add flexibility for define new actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoyonel yoyonel

Labels
Develop enhancement
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@yoyonel