Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hasSufficientFunds props confuse builders #1521

Open
aimensahnoun opened this issue Dec 10, 2024 · 0 comments
Open

hasSufficientFunds props confuse builders #1521

aimensahnoun opened this issue Dec 10, 2024 · 0 comments

Comments

@aimensahnoun
Copy link
Member

aimensahnoun commented Dec 10, 2024

  • hasSufficientFunds takes in an object as a prop, but our docs show normal input.
  • hasSufficientFunds prop naming confuses the builders
hasSufficientFunds({
  request,
  address,
  providerOptions,
  needsGas = true,
}: {
  request: ClientTypes.IRequestData;
  address: string;
  providerOptions?: {
    provider?: providers.Provider;
    nearWalletConnection?: WalletConnection;
  };
  needsGas?: boolean;
}): Promise<boolean> 

Where it says it takes in request, but it actually means requestData. Builders would pass in the request with current format.

@aimensahnoun aimensahnoun converted this from a draft issue Dec 10, 2024
@MantisClone MantisClone moved this from 🆕 New to 🎫 Backlog in Request Network Tech Backlog Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎫 Backlog
Development

No branches or pull requests

1 participant