Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken about:addons page. #825

Closed
Marc05 opened this issue Dec 19, 2016 · 12 comments
Closed

Broken about:addons page. #825

Marc05 opened this issue Dec 19, 2016 · 12 comments

Comments

@Marc05
Copy link

Marc05 commented Dec 19, 2016

The about:addons page on FireFox 50.1.0 is broken. The log shows that the origin about:addons to destination mozilla.org is blocked. I tried adding a rule with the origin of about:addons, but it did not work.

@myrdd
Copy link
Member

myrdd commented Dec 20, 2016 via email

@metadings
Copy link

metadings commented Dec 23, 2016

I did git clone github.com/RequestPolicyContinued/requestpolicy... and I was going to do make which is like make nightly-xpi and I also did make beta-xpi!

(In about:config I've also set xpinstall.signatures.required and xpinstall.whitelist.required to false.)

The nightly didn't work, as in about:addons the click on Einstellungen was about to redirect to about:requestpolicy, which didn't work...

The beta actually worked, however, there are two versions of RequestPolicy... There was one with a default menu and a nice dialog for settings. There was another one with a nice menu and bullshit settings.

Now which RequestPolicy should I make ? I didn't find the one with the "nice dialog"...
On which RequestPolicy do you actually work?

@metadings
Copy link

OHA, you're using git checkout A LOT, but no one uses master or dev-1.0...

Well, now I'm going to look into your CODE ...

@metadings
Copy link

Now I'm on dev-1.0-releases ... however I couldn't succeed.

I've found the one version with a nice menu, I couldn't find the one with the nice dialog ...

@myrdd
Copy link
Member

myrdd commented Dec 23, 2016

@metadings This is very off-topic. Please create a new issue.

I'm working on the dev-1.0 branch. The master branch is RP Legacy.
If you just want to use RP, please install RP from AMO.
If you want to develop RP, I suggest you to run make run. Be sure to disable e10s.
You can also use other Firefox versions, e.g. use make run app_branch=esr.
If you just want to get the xpi, make nightly-xpi is correct. Again, e10s must be disabled.
No idea what you mean by "nice menu/dialog". There's v0.5 and v1.0.
If you've got further questions, please create a new issue!

@metadings
Copy link

What is "AMO" and what "e10s"?

@Marc05
Copy link
Author

Marc05 commented Dec 24, 2016

@myrdd

Be sure to enter "about" in the "scheme" field, and leaving the "host" of the origin empty.

This worked, thank you. I suppose the question now is why did it break, or at least, should this not be allowed by default?

@metadings

What is "AMO" and what "e10s"?

https://www.google.com/search?q=mozilla+amo&ie=utf-8&oe=utf-8
https://www.google.com/search?q=e10s&ie=utf-8&oe=utf-8

@metadings
Copy link

metadings commented Dec 24, 2016

Yes, thank you. I'm now diving deeper into RequestPolicy :-)

Looks like you're using a lot of dependencies, so just downloading, makeing and then running RequestPolicy isn't that easy.

EDIT: I also did sudo apt-get install python-virtualenv. However, I don't want to install some Firefox-nightly, just to edit the RequestPolicy addon...

Look, I don't want to sign the addon every time I want to try a new feature on RequestPolicy.

You may also use a default Firefox installation, having an unsigned RequestPolicy-beta,
where you can work on...

I'm currently using Firefox 50.0 on Linux Mint. (You just have to reset xpinstall.* in about:config.)

@metadings
Copy link

Ya, this looks very well... You're working on the one with the nice menu :-)

@myrdd
Copy link
Member

myrdd commented Dec 28, 2016 via email

@myrdd
Copy link
Member

myrdd commented Dec 28, 2016

I don't want to install some Firefox-nightly, just to edit the RequestPolicy addon...

To use a custom firefox (or seamonkey, or palemoon), just use:
make run app_binary=/path/to/my/firefox.exe
@metadings please continue your questions here: #826

@Marc05
Copy link
Author

Marc05 commented Dec 28, 2016

The destination is https://discovery.addons.mozilla.org/en-US/firefox/discovery/pane/50.1.0/WINNT/normal.

The rule needs to be updated I suppose, instead of adding a new one. I think the last FF version that used the old addons page was like 48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants