-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add endpoint for uploading assets #2130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2130 +/- ##
==========================================
+ Coverage 67.77% 67.82% +0.05%
==========================================
Files 427 431 +4
Lines 23586 23627 +41
==========================================
+ Hits 15985 16026 +41
Misses 7601 7601 ☔ View full report in Codecov by Sentry. |
Replaced by S3StorageService in `researchhub` package.
cbea8ac
to
cea8ecb
Compare
d4e743b
to
c955bf6
Compare
5ac4291
to
6ccbca5
Compare
|
koutst
approved these changes
Feb 25, 2025
yattias
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to create presigned URLs for uploading assets (PDF, JPEG, PNG) for comments, notes and papers.
Example request:
Example response:
The
presigned_url
is the URL the client needs to upload the file using aPUT
request.The
object_url
is the final URL of the uploaded file.