-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Customer Center] Promotional Offers support #3968
[Customer Center] Promotional Offers support #3968
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
d7ef0b6
to
901e975
Compare
901e975
to
181e73b
Compare
181e73b
to
76b9e6a
Compare
76b9e6a
to
f8b3f67
Compare
f8b3f67
to
e86e19c
Compare
e86e19c
to
bf7e1e0
Compare
bf7e1e0
to
9c62db1
Compare
9c62db1
to
76decce
Compare
8caebf1
to
6028e5d
Compare
@JayShortway @tonidero I am changing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments but nothing blocking! I think we can merge this 👍
.active | ||
.values | ||
.lazy | ||
.filter { $0.store == .appStore } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[not for this PR] I was thinking, if the user has a purchase in a different store, we could probably still get it and display whatever information is available in the "no_active" page I guess but nothing to do here right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, will take notes of that
RevenueCatUI/CustomerCenter/ViewModels/FeedbackSurveyViewModel.swift
Outdated
Show resolved
Hide resolved
RevenueCatUI/CustomerCenter/ViewModels/ManageSubscriptionsViewModel.swift
Outdated
Show resolved
Hide resolved
} | ||
|
||
do { | ||
let result = try await Purchases.shared.purchase(product: product, promotionalOffer: promotionalOffer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this, we should move this to the CustomerCenterPurchasesType
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should for sue. I will do it in another PR if you don't mind, since that's going to involve some updates and potentially breaking tests and I need to merge this today
private var viewModel: FeedbackSurveyViewModel | ||
|
||
@Environment(\.localization) | ||
private var localization: CustomerCenterConfigData.Localization? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the back and forth but I'm wondering if we should make this not nullable after all... When these views are created, the configuration should have always loaded so it would be safe to assume this not to be null. That way we don't need checks all over the place for nullability. Or are there any views that require localization before the configuration has loaded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the configuration is the first thing that gets loaded so there should be localization in all screens
This reverts commit 132ac95.
…onse` - ios-13 (#4090) Requested by @vegaro for [06-17-removes_eligibility_from_reponse](https://github.com/RevenueCat/purchases-ios/tree/06-17-removes_eligibility_from_reponse)
…onse` - ios-16 (#4091) Requested by @vegaro for [06-17-removes_eligibility_from_reponse](https://github.com/RevenueCat/purchases-ios/tree/06-17-removes_eligibility_from_reponse)
fa06324
into
integration/customer_support_workflow
### Description This is based on the changes in #3968 This PR: - Moves the strings currently hardcode into the `CustomerCenterConfigData.Localization` object. - Fixes an issue compiling paywall tester introduced in a previous PR - Modifies how we read backend strings to not account for the `common_` prefix, which is already removed by the backend.
Adds displaying a Promotional Offer if the path has an offer id configured