Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title and Close Button Overlaps on Paywall Template 7 on iPhone 15 & 16 Pro Max Devices #4424

Open
8 of 11 tasks
rocxteady opened this issue Oct 29, 2024 · 3 comments
Open
8 of 11 tasks
Labels

Comments

@rocxteady
Copy link

rocxteady commented Oct 29, 2024

Describe the bug
Title and Close Button Overlaps on Paywall Template 7 on iPhone 15 & 16 Pro Max Devices depending on the title's length. It doesn't happen all the time. You may want to check it with the specific text is seen on the screenshot. It happens when there is no image. I don't know if it happens when there is an image. There was no such an issue a few weeks ago. Maybe something started to not working with recent SDK or iOS updates. See the attachment please.

  1. Environment

    1. Platform: iOS
    2. SDK version: 5.7.0 (also main branch)
    3. StoreKit version:
      • StoreKit 1 (default on versions <5.0.0. Can be enabled in versions >=5.0.0 with .with(storeKitVersion: .storeKit1))
      • StoreKit 2 (default on versions >=5.0.0)
    4. OS version: 18.0 & 18.1
    5. Xcode version: Xcode 16.0 & Xcode 16.1
    6. Device and/or simulator:
      • [] Device: N/A. I don't have Pro Max devices.
      • Simulator: iPhone 15 & 16 Pro Max
    7. Environment:
      • Sandbox
      • TestFlight: N/A because I can only test on the simulator.
      • Production: N/A because I can only test on the simulator.
    8. How widespread is the issue. Percentage of devices affected.
  2. Debug logs that reproduce the issue. Complete logs with Purchases.logLevel = .verbose will help us debug this issue.
    I can't share logs because there are too many private information there.

  3. Steps to reproduce, with a description of expected vs. actual behavior

Setup a paywall with Template 7. Enter the exact title as "Premium Planlarımıza Göz Atın". Don't upload any image. You will see title and X button overlaps. See the attachment.

  1. Other information (e.g. stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.)

  2. Additional context
    Suggestion: Don't add ignoring top safe area when there is no header image. Example on Template7View.swift at line 163:

.applyIf(self.configuration.headerImageURL != nil) { view  in
    view.edgesIgnoringSafeArea(.top)
}

Fix on my repo: Fix

Simulator Screenshot - iPhone 15 Pro Max - 2024-10-29 at 18 09 47

@rocxteady rocxteady added the bug label Oct 29, 2024
@RCGitBot
Copy link
Contributor

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

@nyeu
Copy link
Contributor

nyeu commented Oct 31, 2024

Hi @rocxteady, thank you for the report! We'll take a look and make a fix for it.

@rocxteady
Copy link
Author

@nyeu . Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants