Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multi endpoint #25

Open
2 tasks
Revolution1 opened this issue Mar 27, 2018 · 8 comments
Open
2 tasks

support multi endpoint #25

Revolution1 opened this issue Mar 27, 2018 · 8 comments
Labels

Comments

@Revolution1
Copy link
Owner

  • auto retry between endpoint
  • auto balance between endpoint
@gszpura
Copy link

gszpura commented Jun 4, 2018

Hi,
some questions:

  1. will there be an option to choose endpoint and switch only when endpoint failure occurs?
  2. what's the timeline for this feature? When will it be ready?

@Revolution1
Copy link
Owner Author

@gszpura Of course, that is exactly what i'm going to do

As for the timeline, since I thought it's not a urgent feature, currently i'm working on a demo app of etcd3-py. If you truly need it, maybe I can write it first.

Also, thank you for using this lib and welcome to contribute to this project 😀

@gszpura
Copy link

gszpura commented Jun 5, 2018

Reconnection is needed for my usecase since my etcd HA cluster consists of 3 nodes and I would like to auto switch nodes when current one is failing.

If you have an idea and time for writing that I would appreciate it ;]

@stupidchen
Copy link

@gszpura Of course, that is exactly what i'm going to do

As for the timeline, since I thought it's not a urgent feature, currently i'm working on a demo app of etcd3-py. If you truly need it, maybe I can write it first.

Also, thank you for using this lib and welcome to contribute to this project 😀

@Revolution1 Are there any contribution guide about this project? I want to do something about this feature. Could you give me some advice?

@Revolution1
Copy link
Owner Author

Revolution1 commented Feb 22, 2019

@stupidchen you can just write your thoughts about this feature under this issue

I have some ideas about this feature:

Add a EnpointManager to control which endpoint should the client use.

Discover endpoint:

  • user provide
  • by dns resolve
  • by etcd3 member_list api

Auto select a heathy endpoint

  • switch after connection fails
  • active health-check

Of course you can just start coding and create a pull request 😆

The only guide is write clean and readable code (and PEP8 formatted) .

ps: don't forget the test~

@stupidchen
Copy link

@stupidchen you can just write your thoughts about this feature under this issue

I have some ideas about this feature:

Add a EnpointManager to control which endpoint should the client use.

Discover endpoint:

  • user provide
  • by dns resolve
  • by etcd3 member_list api

Auto select a heathy endpoint

  • switch after connection fails
  • positive health-check

Of course you can just start coding and create a pull request 😆

The only guide is write clean and readable code (and PEP8 formatted) .

ps: don't forget the test~

Thanks for your advice! I will start coding in few days!

@dariko
Copy link
Contributor

dariko commented Feb 25, 2019

I've submitted #55 which gives BaseClient the ability to failover between endpoints

@boylegu
Copy link

boylegu commented Nov 28, 2019

How does the current version support clustering? No solution?Release 0.2.0…. It seems so far off in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants