Fix Mifare Classic sim with interactive and reader attack mode never returning console #2198
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The help for
hf mf sim
says that if-i
is passed, "Console will not be returned until simulation finishes or is aborted." However, when using interactive with the reader attack option (hf mf sim -ix
), the console does not return when the simulation is finished or when the button is pressed.This seems to be because in
cmdhfmf.c
, it continues waiting for moreCMD_ACK
s after processing the information from the device, while the device only sendsCMD_ACK
once (after the simulation is finished or the button is pressed.) Addingbreak
after thereaderAttack
line seems to fix this, and doesn't seem to cause any other issues.