-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timewarp and batch-edit so that --uuid option prevents processing of current selection. #1778
Comments
I'm giving it a try to address this topic on --timewarp. Will see later about --batch-edit. FYI, noticed the following behaviour of osxphotos/osxphotos/cli/timewarp.py Line 565 in 56a6601
On Monterey:
|
…ile option prevents processing of current selection. Fixes RhetTbull#1778 Fiz also for --uuid-from-file option in timewarp. Side note: No tests added :(
Thanks for the test data on selection behavior. I'm not sure I can control this as it's the built in behavior of Photos but might be good to document this. |
…-uuid nor --uuid-from-file are speci
…either --uuid nor --uuid-from-file are speci" This reverts commit 3cff021.
… neither --uuid nor --uuid-from-file are used
#1781) * Fix timewarp and batch-edit 9not yet!) so that --uuid and uuid-from-file option prevents processing of current selection. Fixes #1778 Fiz also for --uuid-from-file option in timewarp. Side note: No tests added :( * #1778 Make sure operation on selected pics only if neither --uuid nor --uuid-from-file are speci * Revert "#1778 Make sure operation on selected pics only if neither --uuid nor --uuid-from-file are speci" This reverts commit 3cff021. * #1778 Make sure to operate timewarp on selected pics only if neither --uuid nor --uuid-from-file are used
I've been thinking about how to make
batch-edit
andtimewarp
(and any future commands that operate on selected photos) more useful. One idea I'm thinking of is something like this to useosxphotos query
:osxphotos query --query-options --uuid-only | osxphotos timewarp --uuid-from-file -
This would pipe a list of uuids to timewarp for processing. This avoids having to clutter timewarp with all the query options. It would require a new option for
osxphotos query
that prints only uuid. (This can be accomplished today withosxphotos query --print "{uuid}" --quiet
but that's cumbersome). Open to feedback on improving this approach.Originally posted by @RhetTbull in #1777 (comment)
The text was updated successfully, but these errors were encountered: