Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid selecting SVG elements without class names in updateDataMarks. #248

Open
samussiah opened this issue Apr 2, 2019 · 1 comment
Open

Comments

@samussiah
Copy link
Contributor

for instance in drawBars:

if any custom rect elements are added to these bar groups the new and original elements behave unpredictably

@jwildfire
Copy link
Contributor

Hmm. Makes sense, but also seems like a bit of an edge case, since I'm not sure if we've ever manually added rects to a bargroup. Marking low priority unless you disagree, @samussiah.

I guess easy solution would be to give the webcharts rect objects used in the code above a specific class, and then use it in those selectors. Or better yet, use marks[].rect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants