Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scatter plots circles on the edge of plots are cut in half #250

Open
jwildfire opened this issue May 4, 2019 · 2 comments · May be fixed by #269
Open

Scatter plots circles on the edge of plots are cut in half #250

jwildfire opened this issue May 4, 2019 · 2 comments · May be fixed by #269
Assignees
@samussiah
Labels
bug high priority
Milestone
v1.11.7

Comments

@jwildfire
Copy link
Contributor

As shown below (link)
image
@jwildfire
Copy link
Contributor Author

jwildfire commented May 4, 2019 •
edited
Loading

This is definitely caused by the changes made to clip-path in #235. Not sure the best solution ... probably want to automatically add some padding to the g containing the marks (settings.radius/2 pixels worth) whenever there are circle marks (and also text maybe?). Could also add a mark-specific option to easily toggle the clip-path property ...

@samussiah @pburnsdata Any thoughts?

@jwildfire
Copy link
Contributor Author

jwildfire commented May 8, 2019 •
edited
Loading

I think we can just apply this fix from @samussiah in eDish.

@jwildfire jwildfire added this to the v1.11.7 milestone Nov 18, 2019
samussiah added a commit that referenced this issue Dec 13, 2019
@samussiah
fix #250
3437ef6
@samussiah samussiah self-assigned this Dec 13, 2019
@samussiah samussiah linked a pull request Dec 18, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samussiah samussiah

Labels
bug high priority
Projects
None yet
Milestone
v1.11.7
Development

Successfully merging a pull request may close this issue.

modify chart canvas dimensions for points RhoInc/Webcharts
2 participants
@jwildfire @samussiah