Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update filter logic to work with Webcharts v1.11.4. #119

Closed
samussiah opened this issue Mar 25, 2019 · 2 comments
Closed

Update filter logic to work with Webcharts v1.11.4. #119

samussiah opened this issue Mar 25, 2019 · 2 comments
Milestone
v1.3.0

Comments

@samussiah
Copy link
Contributor

samussiah commented Mar 25, 2019 •
edited by pburnsdata
Loading

update All filter logic in case All appears in the data

RhoInc/Webcharts#236

Test Notes

  1. Download the CAT data, add an "All" value in the "Status" column and upload the updated file.
  2. Select the top "All" option from the Subject Status dropdown and verify that all chart data is displayed.
  3. Select the second "All" option and verify that only a subset is displayed.
@pburnsdata pburnsdata added this to the 1.3.0 milestone Apr 12, 2019
pburnsdata added a commit that referenced this issue Apr 24, 2019
@pburnsdata
fix #119
a471fef
@pburnsdata pburnsdata mentioned this issue Apr 24, 2019
Merged
@samussiah
Copy link
Contributor Author

Tested in Webcharts

@danedexF5
Copy link

@samussiah said this can be skipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
3 participants
@samussiah @danedexF5 @pburnsdata