Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-functional for Oxford Dictionary? #15

Closed
AlexBlandin opened this issue May 27, 2020 · 1 comment · Fixed by #17
Closed

Non-functional for Oxford Dictionary? #15

AlexBlandin opened this issue May 27, 2020 · 1 comment · Fixed by #17

Comments

@AlexBlandin
Copy link

Currently getting (for any input)

> define Oxford

  The source returned an empty result for word: "Oxford"


> define --print-config
{
    "IndentationSize": 2,
    "MerriamWebsterDictionary": {
        "AppKey": ""
    },
    "OxfordDictionary": {
        "AppID": "########",
        "AppKey": "###############################"
    },
    "PreferredSource": "OxfordDictionary",
    "Source": "OxfordDictionary"
}

> define --version
define v0.1.2 (windows/amd64)

Censored ID/key but they are correct. Remains the same even if I don't have the source set (as default with "Source": ""). ID/key are set and correct for both config and envar.

@Rican7
Copy link
Owner

Rican7 commented May 27, 2020

Yeaaaa, the Oxford API was updated and they dropped support for v1. See #12.

I need to get to reviewing #13 soon, which should fix this.

Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants