New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exceptions rather than returning them? #28

Open

oxcafedead opened this issue Apr 4, 2023 · 0 comments

oxcafedead commented Apr 4, 2023 •

edited

Loading

I found some non-clear behavior, and I wonder if it is intentional.

opentelemetry-sdk-workers/packages/opentelemetry-sdk-workers/src/sdk.ts

Lines 290 to 294 in 271b1b2

    
               } catch (reason) { 
        
                   this.endSpan(downstreamRequest, childSpan, reason); 
        
                   return reason; 
        
               } 
        
           }

I would expect throw there instead of return at line 292.

Am I missing something obvious?

The text was updated successfully, but these errors were encountered:

oxcafedead changed the title ~~Throw exceptions rather then returning them?~~ Throw exceptions rather than returning them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment