Skip to content
This repository has been archived by the owner on Jan 30, 2021. It is now read-only.

Add Danger checks #131

Open
4 tasks
armcknight opened this issue May 31, 2019 · 0 comments
Open
4 tasks

Add Danger checks #131

armcknight opened this issue May 31, 2019 · 0 comments

Comments

@armcknight
Copy link

armcknight commented May 31, 2019

Some things that come up fairly often in my own development and in code reviews (both things asked for but also missed which lead to confusion later) are if a commit or PR branch contains:

  • changes to a pbxproj or file renames and running synx produces new changes
  • changes to the Podfile and a pod install produces new changes in Pods/, Podfile.lock or the main pbxproj
  • changes to Podfile.lock or Pods/ but not Podfile (maybe others like this for Gemfiles etc)
  • changes to signing team or provisioning profile settings

Thought about suggesting adding as a warning in a precommit hook, but worried about the amount of time it would take to create a commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant