Fix #135 Bundle Identifier issue. #148
Conversation
…dle identifier would not be updated correctly.
Current coverage for Services.framework is
|
|
testAuthenticatedRequestWithCredentials test is passing locally in Xcode, command line and on test-xcode-10-2 in Circle CI but not in danger... Investigating. |
|
Test fail most likely due to #123 OHHTTPStub Tests failing inconsistently. Will try to force rebuild. In the meantime, those tests may need to be commented out until that issue is tracked down and resolved. |
…dentifier issue, and 2. there's a separate task/branch/pr to investigate the APIClientTests issues.
|
Although all tests are passing and are fine to be merged, I believe Issue #123 is still present and more work is likely needed. Tests as currently constructed are likely fine from the perspective of OHHTTPStubs. See https://github.com/AliSoftware/OHHTTPStubs/wiki/OHHTTPStubs-and-asynchronous-tests Either formulation (do XCTAssert() in waitForExpectations:timeout:handler or after wairForExpectations:timeout) should be fine there. That leaves APIClient itself although it's a very light layer on top of Alamofire. Next step is probably to continue work on #123. I don't believe that should hold up merging this specific PR though as it's simply fixing a bundle identifier issue. |
|
Closing as this template is no longer in active use. |
Reordered replace command in generate_template to fix issue where bundle identifier would not be updated correctly.
Fixes #135