Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1 support #47

Closed
crpmax opened this issue Mar 20, 2022 · 5 comments
Closed

PHP 8.1 support #47

crpmax opened this issue Mar 20, 2022 · 5 comments

Comments

@crpmax
Copy link

crpmax commented Mar 20, 2022

Hello,
please add PHP 8.1 support.

With PHP 8.1 it throws strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
in QrPayment.php on line 195.

Thanks.
@RikudouSage
Copy link
Owner

Which version are you using?

@crpmax
Copy link
Author

crpmax commented Mar 20, 2022

I am using PHP 8.1.3
But the deprecation comes from PHP 8.1
look here: https://www.php.net/manual/en/migration81.deprecated.php

@RikudouSage
Copy link
Owner

Yeah, sorry, I meant the version of my library, as far as I know the error shouldn't be triggered in the newest version.

@crpmax
Copy link
Author

crpmax commented Mar 20, 2022

I see the problem.
I ran composer update before, so I thought I had the latest version, but it was v4.2.2 - the latest v4.
But for version 5 I see I have to rewrite the code a bit...

Thank you anyway and sorry for my error.

@RikudouSage
Copy link
Owner

Glad I could help! Let me know if it works after you update to 5.x, I'll leave the issue open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RikudouSage @crpmax