Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning due to hardcoded icon in messageItem #170

Open
CorneeldH opened this issue Sep 19, 2022 · 0 comments
Open

Warning due to hardcoded icon in messageItem #170

CorneeldH opened this issue Sep 19, 2022 · 0 comments

Comments

@CorneeldH
Copy link

Hi,

We get the following warnings with out shiny app:

This Font Awesome icon ('clock-o') does not exist:
* if providing a custom `html_dependency` these `name` checks can 
  be deactivated with `verify_fa = FALSE`

After some searching we found the issue, it is hardcoded in the messageItem function shinydashboardplus that we use:

messageItem <- function (from, message, icon = shiny::icon("user"), time = NULL, 
                         href = NULL, inputId = NULL) {
  tagAssert(icon, type = "i")
  if (is.null(href)) href <- "#"
  shiny::tags$li(
    shiny::a(
      id = inputId, 
      class = if (!is.null(inputId)) "action-button",
      href = href, 
      icon, 
      shiny::h4(from, if (!is.null(time)) 
        shiny::tags$small(shiny::icon("clock"), time)), shiny::p(message)
    )
  )

Maybe update the icon or make it an optional attribute? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant