Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misplaced (and redundant) test case #10

Open
Bamiji opened this issue Oct 18, 2019 · 0 comments
Open

Misplaced (and redundant) test case #10

Bamiji opened this issue Oct 18, 2019 · 0 comments

Comments

@Bamiji
Copy link
Contributor

Bamiji commented Oct 18, 2019

LoRDeckCodes/LoRDeckCodes_Tests/UnitTest1.cs

Line 270 in b2211d7

deck.Add(new CardCodeAndCount() { CardCode = "01DE002", Count = 0 });

This tests bad card count under a test for bad card codes, and this specific case is also more aptly tested in another test (BadCount()). Suggest changing to test for badly formatted set number such as '0DE002', which currently isn't tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bamiji