Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up error handling for frontend #115

Open
wstrm opened this issue Dec 2, 2018 · 2 comments
Open

Clean up error handling for frontend #115

wstrm opened this issue Dec 2, 2018 · 2 comments
Labels
Enhancement New feature or request On hold The ticket/PR is on hold Partially fixed

Comments

@wstrm
Copy link
Member

wstrm commented Dec 2, 2018

The error handling is horrible right now.

The backend sometimes just returns the internal error to the frontend.

I'm not sure how, but we should try to make it more DRY - maybe just let the handler return a error and have some kind of wrapper that takes care of logging and returning a cleaned up error to the front end?

I'd also like to use my own library, github.com/willeponken/causerr, just because 🙄

... Ummm, we should probably wait with this though until we got most logic working 😭

@Hjortsberg
Copy link
Member

Hmm yes, whilst it is good to have nice error messages, this sounds a bit like premature optimization to me.
Do it, only IF time is available OR necessary! 💃

@Hjortsberg Hjortsberg added Enhancement New feature or request On hold The ticket/PR is on hold labels Dec 2, 2018
@wstrm wstrm removed the On hold The ticket/PR is on hold label Dec 11, 2018
@wstrm wstrm self-assigned this Dec 11, 2018
@wstrm
Copy link
Member Author

wstrm commented Jan 8, 2019

We're fixin' this l8or!!! On hold.

@wstrm wstrm added the On hold The ticket/PR is on hold label Jan 8, 2019
@wstrm wstrm changed the title Clean up error handling for backend and frontend Clean up error handling for frontend Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request On hold The ticket/PR is on hold Partially fixed
Projects
None yet
Development

No branches or pull requests

2 participants