Skip to content

Latest commit

 

History

History
116 lines (82 loc) · 4.24 KB

CONTRIBUTING.md

File metadata and controls

116 lines (82 loc) · 4.24 KB
Raw

Contributing Guide

Contributing to angular-translate is fairly easy. This document shows you how to get the project, run all provided tests and generate a production ready build.

It also covers provided grunt tasks, that help you developing on angular-translate.

Dependencies

To make sure, that the following instructions work, please install the following dependecies on you machine:

  • Node.js
  • npm
  • Git

If you install node through the binary installation file, npm will be already there. When npm is installed, use it to install the needed npm packages:

  • bower npm install -g bower
  • grunt-cli npm install -g grunt-cli
  • karma npm install -g karma

Installation

To get the source of angular-translate clone the git repository via:

$ git clone https://github.com/angular-translate/angular-translate

This will clone the complete source to your local machine. Navigate to the project folder and install all needed dependencies via npm:

$ npm install

angular-translate is now installed and ready to be built.

Building

angular-translate comes with a few grunt tasks which help you to automate the development process. The following grunt tasks are provided:

grunt

Running grunt without any parameters, will actually execute the registered default task. This task is currently nothing more then a lint task, to make sure that your JavaScript code is written well.

grunt test

grunt test executes (as you might thought) the unit tests, which are located in test/unit. The task uses karma the spectacular test runner to executes the tests with the jasmine testing framework.

grunt build

You only have to use this task, if you want to generate a production ready build of angular-translate. This task will also lint, test and minify the source. After running this task, you'll find the following files in a generated dist folder:

dist/angular-translate-x.x.x.js
dist/angular-translate-x.x.x.min.js

grunt watch

This task will watch all relevant files. When it notice a change, it'll run the lint and test task. Use this task while developing on the source to make sure, everytime you make a change you get notified if your code is incosistent or doesn't pass the tests.

grunt dev

This task extends watch. In addition, it will lint, test and copy the result into demo/. After this, just like watch it will run these steps every time a file has changed. On top of that, this tasks supports live reloading (on default port).

This task works in harmony with grunt server.

grunt server

This tasks provides a simple http server on port 3005. If you start it on your machine, you have access to the project`s demos with real XHR operations.

Example: http://localhost:3005/demo/async-loader/index.html

Under the hood, we use a complete Express server stack. You will find the server configuration at server.js and additional routes for our demos at demo/server_routes.js.

Contributing/Submitting changes

  • Checkout a new branch based on master and name it to what you intend to do:
    • Example: 
      $ git checkout -b BRANCH_NAME
    • Use one branch per fix/feature
  • Make your changes
    • Make sure to provide a spec for unit tests
    • Run your tests with either karma start or grunt test
    • When all tests pass, everything's fine
  • Commit your changes
  • Make a pull request
    • Make sure you send the PR to the canary branch
    • Travis CI is watching you!

If you follow these instructions, your PR will land pretty safety in the main repo!