Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLADE-23 ⁃ Don't Work with Laravel 5.1 #20

Closed
headersalreadysent opened this issue Jun 10, 2015 · 7 comments
Closed

BLADE-23 ⁃ Don't Work with Laravel 5.1 #20

headersalreadysent opened this issue Jun 10, 2015 · 7 comments

Comments

@headersalreadysent
Copy link

headersalreadysent commented Jun 10, 2015

laradic/support wants 5.0.* and laravel 5.1 cant work with blade-extensions.
Any update is near?

@RobinRadic
Copy link
Owner

sure, i'l push an update soon. can't name any time/date but should be within the next few days.

@Syra
Copy link

Syra commented Jun 11, 2015

Hello,
Nice to hear it.
Just say if you need any help with that.

Thanks,
Alex

@lahaxearnaud
Copy link

Hello,

It will be great !

Thanks,

Arnaud

@jernejrostan
Copy link

Did anything changed that much in 5.1 that blade-extensions is so dependent on? Any release date of update? :)

@younes0
Copy link
Contributor

younes0 commented Jun 15, 2015

Check crhayes/blade-partials#7

@RobinRadic
Copy link
Owner

@jernejrostan Laravel 5.1 removed some methods from the BladeCompiler class that provided regex strings for simple directive matchers, which was the main culprit.

@RobinRadic
Copy link
Owner

@Syra Thanks Alex. Altough this issue is now fixed, PR's are always welcome :)

@RobinRadic RobinRadic changed the title Don't Work with Laravel 5.1 BLADE-23 ⁃ Don't Work with Laravel 5.1 Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants