Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Install dependencies" button didn't show; thus weird behaviour #75

Open
dgxo opened this issue Jan 16, 2025 · 5 comments
Open

"Install dependencies" button didn't show; thus weird behaviour #75

dgxo opened this issue Jan 16, 2025 · 5 comments
Labels
bug Something isn't working

Comments

@dgxo
Copy link

dgxo commented Jan 16, 2025

After pressing the 'Login' button and giving access, I'm redirected to the local server where it says the following:

Error: Login request failed.
400, message="Bad status line 'HTTP/1.1 200 '", url=URL('https://apis.roblox.com/oauth/v1/token')

Tried with Firefox and Chrome (obviously won't make a difference since it's the backend).

When initially installing the plugin from Releases I was never prompted to install the required dependencies, so I encountered weird behaviour. See #issuecomment-2611404130.

@dgxo dgxo changed the title Cannot login: Cannot login: Bad status line 'HTTP/1.1 200 ' Jan 16, 2025
@Nightriff
Copy link
Collaborator

Seems like the http client used in the plugin is unable to interpret the HTTP/1.1 200 as a valid status from the /oauth/v1/token Roblox API? I wonder if it has to do with that trailing space.

I'm unable to reproduce this, can you share which version of Blender you're running? And does this happen every time, occasionally, or just once?

@Nightriff Nightriff added the bug Something isn't working label Jan 21, 2025
@dgxo
Copy link
Author

dgxo commented Jan 24, 2025

Every time I tried to login it failed and had the same result, or something with a very similar error which I don't remember.

Unfortunately now I am unable to reproduce this bug, but have instead encountered more weird behaviour
The response after completing the OAuth flow seems to depend on whether or not I select an account in the Accounts list on the OAuth page, and if so which account(s);

No account

Internal client error.
No creators were authorized during login

Group or my account + group

Internal client error.
'userFacingMessage'

Only my account

No response, web server appears offline

I only own one group, so maybe the behaviour is different with multiple groups???
I'm immensely confused on why any of this is happening, but here's my system info, with the username redacted for privacy reasons;
system-info.txt (MacOS w/ Blender 4.2.1 LTS, latest plugin version)
The exact same behaviour occurs with the latest Blender version, 4.3.2.

@dgxo
Copy link
Author

dgxo commented Jan 24, 2025

Okay, just tried directly using the actual latest version directly from the repo instead of from releases, and it asked me to install the dependencies, which it didn't do when I first installed the plugin. It worked fine.
Not going to close this issue as it's still a bug that I was never prompted to install the dependencies.

@dgxo dgxo changed the title Cannot login: Bad status line 'HTTP/1.1 200 ' "Install dependencies" button didn't show; weird behaviour Jan 24, 2025
@dgxo dgxo changed the title "Install dependencies" button didn't show; weird behaviour "Install dependencies" button didn't show; thus weird behaviour Jan 24, 2025
@Nightriff
Copy link
Collaborator

Nightriff commented Feb 11, 2025

No creators were authorized during login

This error is expected if no authorizations are made, since the add-on wouldn't have anywhere to upload to. It comes from here

'userFacingMessage'

This is fascinating because that particular string is used as a key to look up the error message in an error object here. I'm surprised this is somehow able to get interpreted literally. This is a bug, but I'm not sure how it works yet.

No response, web server appears offline

This is unexpected, perhaps there's an issue with the error handling around here if anyone is looking to investigate, this seems like a bug.

Dependency installation wasn't prompted initially

Also unexpected, that indicates somehow is_finished_installing_dependencies was truthy in this logic without performing an installation. This property is initially populated based on the existence of the public dependency directory, here (logic being, if the directory exists, then it must exist because dependencies have been installed). I can't imagine why that directory would exist outside of a previous installation attempt being started. Are you completely sure you hadn't started an installation attempt before that at some point?

Installing directly from the repo instead of the release page

There are a couple pending changes that haven't been released yet, but they wouldn't affect dependency installation. It's likely the removal of the add-on's files also removed the public dependencies folder (see above) which reset the property value.

@dgxo
Copy link
Author

dgxo commented Feb 12, 2025

I think I had previously installed (and uninstalled, maybe changed Blender version and it was auto removed?) the addon a few months before first trying it from releases (and then the cloned repo), maybe the dependenices had changed in that time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants