Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scroll stuck after coming back to a channel again #33876

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: scroll stuck after coming back to a channel again #33876

wants to merge 4 commits into from
+58 −19

Conversation

swastikCommits
Copy link

Proposed changes (including videos or screenshots)

When you visit a channel and come back to it, you can't load history: infinite scroll not working and you can't get previous messages.

Issue(s)

Closes #33469

Steps to test or reproduce

Go to a channel (ie: general)
Go to another channel (ie: support)
Go back to the previous channel (ie: general)
Scroll to the top of the page until older messages are loaded in ajax

Further comments

@swastikCommits swastikCommits requested a review from a team as a code owner November 4, 2024 14:11
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 4, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5ab6b6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ swastikCommits
❌ Swastik Ranjan Panigrahi

Swastik Ranjan Panigrahi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@swastikCommits
Copy link
Author

@reetp can you help me I had by mistake instead of commiting as per my github username, I had committed as Swastik Ranjan
Panigrahi

@reetp
Copy link

reetp commented Nov 4, 2024

Nothing I can do I'm afraid.

@swastikCommits
Copy link
Author

Nothing I can do I'm afraid.

Can you tag any reviewer/maintainer to surpass the CLA or guide my to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite scroll does not work to load history of visited channels
3 participants
@swastikCommits @CLAassistant @reetp