Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly convert plain text in brackets that is not a link #1132

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

paviad
Copy link

@paviad paviad commented Aug 13, 2023

Proposed changes (including videos or screenshots)

Properly convert the following:

  1. [Title 1] foo [TItle 2](http://bar.com) to html <p>[Title 1] foo <a href="http://bar.com">Title 2</a>
  2. [Foo [Bar _emph_ Baz] Waz](http://bar.com) to html <a href="http://bar.com">Foo [Bar <i>emph</i> Baz] Waz</a>

Issue(s)

Closes #1131

Further comments

Tests included

@CLAassistant
Copy link

CLAassistant commented Aug 13, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paviad
Copy link
Author

paviad commented Aug 19, 2023

CLA signing is not properly detected even after days have gone by. I have signed and rechecked multiple times.

@dougfabris dougfabris changed the base branch from develop to main September 13, 2023 19:55
@dougfabris dougfabris force-pushed the main branch 4 times, most recently from 77be55a to a97c7f0 Compare September 15, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

message-parser: markdown link parsing is wrong
2 participants