-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multi select #1282
fix: multi select #1282
Conversation
|
|
Yes I check the pr earlier but it resolves only the collapse not the scrolling part |
@SySagar Yeah, that's good. Now, you can focus on the scrolling issue only, as the other problem has already been addressed. Having multiple PRs solving the same issue will result in confusion. You can remove that commit and force push. |
Wouldn’t it be good if this pr closes both or I can update the other pr don’t know if that is possible |
@SySagar , but that has already been addressed, right? There has been effort put into solving the issue. Having multiple PRs solving the same issue may waste others' efforts. |
No worried I will force push this will that be ok?or should I update that pr of other person |
Yeah sure. Thank you for your understanding, You can also update your issue solving the scroll issue. |
You won't be able to edit PR of other person. So you can go with removing the second commit and force push. |
Hi there, thanks for the contribution! 🚀 💯 We're planning an entire replacement of all the components related to Questions? Help needed? Feature Requests?
|
fix(multi select): Collapse and scroll on open fixed
Proposed changes (including videos or screenshots)
Issue(s)
Closes #1281
Closes #1284